fix(teams): act on membership_changed directly instead of diffing - #255
Merged
Merged
Conversation
The server now sends membership_changed:added:{team_id} /
membership_changed:removed:{team_id}, so the client can join or evict
that exact team without re-fetching the whole team list, diffing it,
and retrying with backoff on a zero delta. The bare event (older server
build) still falls back to the old diff-based path; vault-key-wrap
notifications now arrive as their own vault_key_changed event instead
of a fake membership change.
Closes #236
kipavy
force-pushed
the
fix-236-membership-changed-id
branch
from
September 10, 2026 11:04
376297a to
067d6ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
membership_changed:added:{team_id}/membership_changed:removed:{team_id}, so this client acts on that exact team directly instead of re-fetching the whole team list, diffing it, and retrying with backoff on a zero delta.membership_changedevent still falls back to the old diff-based path, for a server pod on an older build mid-rollout.vault_key_changedevent instead of riding a fake membership change (issue Vault join & first-access experience — welcome moment + honest 'waiting for owner key' state #70's zero-delta case).Test plan
pnpm exec tsc --noEmitpnpm exec vitest run src/services/teamMembershipEvents.test.ts(new coverage for the event parser + existing delta logic)