Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/routes/invitations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ pub async fn accept_invitation(
Some(user_email.clone()),
Some(json!({ "role": role, "via": "invitation" })),
));
notifier.notify_membership_changed(auth.0);
notifier.notify_membership_changed(auth.0, team_id, true);
notify_team_members_changed(&pool, &notifier, team_id).await;
Ok(StatusCode::NO_CONTENT)
}
Expand Down Expand Up @@ -298,7 +298,7 @@ pub async fn accept_my_pending_invitation(
user_email,
Some(json!({ "role": role, "via": "in_app_invite" })),
));
notifier.notify_membership_changed(auth.0);
notifier.notify_membership_changed(auth.0, team_id, true);
notify_team_members_changed(&pool, &notifier, team_id).await;
Ok(StatusCode::NO_CONTENT)
}
Expand Down
8 changes: 6 additions & 2 deletions src/routes/sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,12 @@ pub async fn sync_stream(
Ok(SyncEvent::BlobPushed { user_id: uid, device_id }) if uid == user_id => {
Some(Ok(Event::default().data(device_id)))
}
Ok(SyncEvent::MembershipChanged { user_id: uid }) if uid == user_id => {
Some(Ok(Event::default().data("membership_changed")))
Ok(SyncEvent::MembershipChanged { user_id: uid, team_id, added }) if uid == user_id => {
let kind = if added { "added" } else { "removed" };
Some(Ok(Event::default().data(format!("membership_changed:{}:{}", kind, team_id))))
}
Ok(SyncEvent::VaultKeyChanged { user_id: uid }) if uid == user_id => {
Some(Ok(Event::default().data("vault_key_changed")))
}
Ok(SyncEvent::PresenceChanged { recipient, subject, online }) if recipient == user_id => {
let status = if online { "online" } else { "offline" };
Expand Down
4 changes: 2 additions & 2 deletions src/routes/team_grants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ pub async fn redeem_grant(
// The joiner's own devices refetch their team list; every member — the
// joiner included — gets `team_members:<team_id>`, which is the event an
// online key-holder's reconcileTeamVaultKeys listens for.
notifier.notify_membership_changed(auth.0);
notifier.notify_membership_changed(auth.0, locked.team_id, true);
notify_team_members_changed(&pool, &notifier, locked.team_id).await;

Ok(Json(response))
Expand Down Expand Up @@ -1023,7 +1023,7 @@ mod tests {
{
roster_events.push(user_id)
}
SyncEvent::MembershipChanged { user_id } => membership_events.push(user_id),
SyncEvent::MembershipChanged { user_id, .. } => membership_events.push(user_id),
_ => {}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/routes/team_sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ pub async fn put_vault_keys(

info!(team_id = %team_id, upserter = %auth.0, key_count = body.keys.len(), "Vault keys upserted");
for user_id in vault_key_notification_targets(auth.0, &body.keys) {
sync_notifier.notify_membership_changed(user_id);
sync_notifier.notify_vault_key_changed(user_id);
}
Ok(StatusCode::NO_CONTENT)
}
Expand Down Expand Up @@ -525,7 +525,7 @@ pub async fn rotate_vault_key(

info!(team_id = %team_id, rotated_by = %auth.0, new_epoch = next_version, member_count = body.keys.len(), "Team vault key rotated");
for user_id in vault_key_notification_targets(auth.0, &body.keys) {
sync_notifier.notify_membership_changed(user_id);
sync_notifier.notify_vault_key_changed(user_id);
}
Ok(StatusCode::NO_CONTENT)
}
Expand Down
4 changes: 2 additions & 2 deletions src/routes/teams.rs
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ pub async fn remove_member(
removed_display_name,
None,
));
notifier.notify_membership_changed(user_id);
notifier.notify_membership_changed(user_id, team_id, false);
notify_team_members_changed(&pool, &notifier, team_id).await;
Ok(StatusCode::NO_CONTENT)
}
Expand Down Expand Up @@ -629,7 +629,7 @@ pub async fn delete_team(

info!(team_id = %team_id, deleted_by = %auth.0, "Team deleted by owner");
for member_id in member_ids {
notifier.notify_membership_changed(member_id);
notifier.notify_membership_changed(member_id, team_id, false);
}
Ok(StatusCode::NO_CONTENT)
}
Expand Down
13 changes: 10 additions & 3 deletions src/sync_notifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ pub enum SyncEvent {
/// Another device pushed a blob for this user.
BlobPushed { user_id: Uuid, device_id: String },
/// The user's team membership changed (added to or removed from a team).
MembershipChanged { user_id: Uuid },
MembershipChanged { user_id: Uuid, team_id: Uuid, added: bool },
/// A vault key was (re)wrapped for a user who was already a member.
VaultKeyChanged { user_id: Uuid },
/// A teammate's online/offline status changed. `recipient` is who should receive it.
PresenceChanged {
recipient: Uuid,
Expand Down Expand Up @@ -52,8 +54,13 @@ impl SyncNotifier {
});
}

pub fn notify_membership_changed(&self, user_id: Uuid) {
let _ = self.0.tx.send(SyncEvent::MembershipChanged { user_id });
pub fn notify_membership_changed(&self, user_id: Uuid, team_id: Uuid, added: bool) {
let _ = self.0.tx.send(SyncEvent::MembershipChanged { user_id, team_id, added });
}

/// Not a membership change — see `SyncEvent::VaultKeyChanged`.
pub fn notify_vault_key_changed(&self, user_id: Uuid) {
let _ = self.0.tx.send(SyncEvent::VaultKeyChanged { user_id });
}

/// Tell this user's own devices to refetch `/my/pending-invitations`, after
Expand Down