fix(waterfall): connect horizontal leader lines at facing bar edges - #4697
Merged
Merged
Conversation
skie1997
reviewed
Sep 20, 2026
skie1997
left a comment
Contributor
There was a problem hiding this comment.
Review 完成,复核结论已评论到方向判断对应代码行。本地定向验证 3 个测试文件、23 项通过(复用本机已有依赖)。
验证边界:远端 TEST CI 通过,但 Bug Server CI 最终为 photo test status: pending、totalCount=0,因此尚无截图回归结论;size 报 2.43 MB,超过 2 MB 限制 425.46 kB。上述 CI 结果不能证明是本次方向判断改动引入的新缺陷,未据此提交缺陷结论。
skie1997
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个分支是...
🐞 Bugserver 用例 id
649d7f2452a1e9eec95f9f1c
💡 问题的背景&解决方案
横向瀑布图的连接线错误地连接两根柱的外侧边缘,虚线覆盖柱体边缘。原始用例中,14 条连接线都由应有的 10px 延长成 40px。
14c5e3e6f为修复 #4580 引入了根据 axis inverse 翻转端点的逻辑,但横向 Y 轴默认inverse=true才表示分类从上往下排列,不能与 X 轴使用相同的方向判断。本次按屏幕分类方向归一化 Y 轴 inverse,保留纵向反向轴及两种累计模式的正确端点选择。私有方法改名为_isCategoryAxisReversed,明确其表示屏幕方向;未增加每图元分配。将原先直接断言私有方法布尔值的测试替换为真实图表几何测试:从渲染柱体独立计算相邻边界,再检查连接线端点,覆盖横向/纵向、inverse 未指定/false/true、increase/decrease,以及配置更新。
同一本地源码构建、同一原始 spec,左图仅代入修复前的方向判断,右图使用本次实际实现。修复后所有柱的几何属性不变,14 条连接线均恢复为 10px。
📝 Changelog
☑️ 自测
tsc --noEmit、定向 ESLint、Prettier、git diff --check通过。🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough