Skip to content

Slash shortcut no longer fires while typing in editable fields - #1589

Merged
RhysSullivan merged 1 commit into
mainfrom
fix/slash-search-hotkey
Aug 14, 2026
Merged

Slash shortcut no longer fires while typing in editable fields#1589
RhysSullivan merged 1 commit into
mainfrom
fix/slash-search-hotkey

Conversation

@RhysSullivan

@RhysSullivan RhysSullivan commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

The tool tree binds a document-level / keydown that focuses the tool filter. The guard only excluded INPUT, so typing / in a textarea, contenteditable, or select on any page with the tool tree stole focus mid-word (e.g. a URL died at https:).

The handler now ignores the shortcut when the active element is any editable target (input, textarea, select, contenteditable) or when a modifier is held, so browser shortcuts like Cmd+/ pass through. Plain / with nothing focused still focuses the filter.

Both clips type Try https://example.com/path into a textarea (added to the tools page for the repro) with real key events.

Before

Typing dies at Try https: — the first / steals focus into the tool filter and the rest of the URL lands there instead.

before: slash steals focus mid-URL

After

The full URL lands in the textarea; pressing / with nothing focused still jumps to the filter and types probe.

after: URL types cleanly, slash shortcut still works

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud f3b369f Aug 14 2026, 09:20 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing f3b369f Commit Preview URL

Branch Preview URL
Aug 14 2026, 09:20 AM

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1589

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1589

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1589

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1589

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1589

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1589

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1589

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1589

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1589

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1589

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1589

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1589

executor

npm i https://pkg.pr.new/executor@1589

commit: f3b369f

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 14, 2026 10:05
@RhysSullivan
RhysSullivan merged commit e981528 into main Aug 14, 2026
20 of 21 checks passed
@RhysSullivan
RhysSullivan deleted the fix/slash-search-hotkey branch August 14, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant