Slash shortcut no longer fires while typing in editable fields - #1589
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | f3b369f | Aug 14 2026, 09:20 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | f3b369f | Commit Preview URL Branch Preview URL |
Aug 14 2026, 09:20 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool tree binds a document-level
/keydown that focuses the tool filter. The guard only excludedINPUT, so typing/in a textarea, contenteditable, or select on any page with the tool tree stole focus mid-word (e.g. a URL died athttps:).The handler now ignores the shortcut when the active element is any editable target (input, textarea, select, contenteditable) or when a modifier is held, so browser shortcuts like Cmd+/ pass through. Plain
/with nothing focused still focuses the filter.Both clips type
Try https://example.com/pathinto a textarea (added to the tools page for the repro) with real key events.Before
Typing dies at
Try https:— the first/steals focus into the tool filter and the rest of the URL lands there instead.After
The full URL lands in the textarea; pressing
/with nothing focused still jumps to the filter and typesprobe.