ci: pin release workflow actions - #99
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.github/workflows/release.ymlpublishes to PyPI with trusted publishing, sothe job holds
id-token: write, but its three actions use floating refs:A moved tag or branch would change what code runs in the publishing job
without any review in this repository.
tests.ymlandlinter.ymlalreadypin their actions to full commit SHAs and run checkout with
persist-credentials: false; the release job is the only one that departsfrom that pattern, and it is the one with publish permissions.
Fix: pin all three actions to the commits the floating refs resolve to
today, keep the version in a trailing comment, add
persist-credentials: falseto checkout, and fix theinz 'dist/'commenttypo. Trigger, permissions, environment, build and publish behavior are
unchanged.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
actions/checkout@v5→fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09,astral-sh/setup-uv@v8.2.0→fac544c07dec837d0ccb6301d7b5580bf5edae39,pypa/gh-action-pypi-publish@release/v1→dc37677b2e1c63e2034f94d8a5b11f265b73ba33uvx pre-commit run --all-files— all hooks passed, including ShellCheck v0.10.0python -m unittest discover -s tests -p 'test_*.py'— 148 tests OK (4 skipped)git diff --check— passed🤖 Generated with Claude Code