feat(governance): update governance rules to use domain tech councils - #69
Open
damaz91 wants to merge 2 commits into
Open
feat(governance): update governance rules to use domain tech councils#69damaz91 wants to merge 2 commits into
damaz91 wants to merge 2 commits into
Conversation
- Update team_hierarchy across all repository governance rule configurations (.github, conformance, js-sdk, meeting-minutes, python-sdk, samples, ucp, and ucp-schema) to replace legacy tech-council with shopping-tech-council, food-tech-council, lodging-tech-council, and payments-tech-council at Level 3. - Update meeting-minutes-rules.yml to reference shopping-tech-council. - Update pr_validator.py to gracefully handle 404 (team not found) when fetching team memberships from GitHub, preventing CI breaks during team renames and migrations. - Update documentation in README.md and validation_report.md. - Add test coverage in test_pr_validator.py.
ptiper
approved these changes
Sep 9, 2026
ptiper
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, thanks for adding the graceful 404 handling and adding the Domain Tech Councils to the clearance hierarchy! Approving, with a couple of suggestions for meeting-minutes-rules.yml:
- Domain-specific rules: Rather than routing all tc/** to shopping-tech-council, let's break this into vertical-specific rules (tc/shopping/, tc/food/, tc/lodging/, tc/payments/) now that PR #35 has organized the folder structure by council. This ensures the bot's PR status comment asks for approval from the correct domain council instead of directing everyone to shopping-tech-council. Shared templates (tc/*.md) can fall back to devops-maintainers.
- Retain tech-council: 3 in team_hierarchy: Consider keeping tech-council: 3 in team_hierarchy across the rule sets during the transition. meeting-minutes/.github/CODEOWNERS still points /tc/ to @Universal-Commerce-Protocol/tech-council, and removing it from team_hierarchy causes pr_validator.py to drop those assigned reviewers and report 0 eligible reviewers assigned. Once this PR lands, we can update CODEOWNERS in meeting-minutes to point to each domain team.
…in tech-council in hierarchy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the UCP clearance hierarchy across all repository governance rules to transition from the single legacy
tech-councilteam to the domain-specific Technical Councils (shopping-tech-council,food-tech-council,lodging-tech-council, andpayments-tech-council) at Level 3.Key changes:
team_hierarchyupdates: Updated all 8 governance rules files (ucp-rules.yml,.github-rules.yml,conformance-rules.yml,js-sdk-rules.yml,meeting-minutes-rules.yml,python-sdk-rules.yml,samples-rules.yml, anducp-schema-rules.yml) to defineshopping-tech-council,food-tech-council,lodging-tech-council, andpayments-tech-councilat Level 3.meeting-minutes-rules.yml: Updated thetech_council_minutesrule frommin_team: "tech-council"tomin_team: "shopping-tech-council".pr_validator.py: Added graceful handling for HTTP 404 (team not found) when querying GitHub team memberships. This logs a warning and treats the team as empty rather than raising an unhandled exception, ensuring resilience during team migrations.org-tools/governance/README.mdandorg-tools/governance/docs/validation_report.mdto reflect the domain Tech Councils hierarchy.test_fetch_team_not_found_handledintest_pr_validator.py.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).