Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production behavior
The Token image now ships the Chromium revision required by Playwright 1.63.0. The
/potokenroute no longer fails because the runner is missing its browser executable.Deployment requirements
Publish the Token image from
mainand pin the production token service to its immutable digest. Preserve the current Token image and secret volume as the rollback point.Runtime verification
/healthreturns successfully./potoken?videoId=dQw4w9WgXcQreturns successfully on the built image.Tests
git diff --check.Rollback
Restore the previous Token image digest and recreate only
typetype-token.