feat(errconnect): add connect-go error code mapping - #25
Conversation
yordis
commented
Sep 5, 2026
- Services adopting Connect RPC need to translate trogonerror codes into connect.Code, but not every consumer of this module uses Connect and shouldn't pay for the dependency.
- Kept as a subpackage in the same module (not a nested go.mod) so the project stays on a single version and release-please only tracks one component; Go still only compiles/links errconnect for callers who actually import it.
Services adopting Connect RPC need to translate trogonerror codes into connect.Code without every consumer of the root module paying for the connect-go dependency. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview
Tests cover each known code plus the unknown-code fallback. Reviewed by Cursor Bugbot for commit be49391. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe PR adds an ChangesConnect error-code mapping
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds Connect RPC status-code conversion for existing errors, with unknown values safely reported as Internal. The implementation and dependency update are ready to merge. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |