chore(ci): pin actions to immutable commit SHAs #41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,11 +13,11 @@ concurrency: | |
| jobs: | ||
| check: | ||
| name: Check | ||
| runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
|
|
@@ -33,7 +33,7 @@ jobs: | |
| fi | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1.15.0 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
|
|
@@ -64,19 +64,19 @@ jobs: | |
| # limit stays at the default 4 so peak load per runner is unchanged. | ||
| test: | ||
| name: Test | ||
| runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
| !/.repos/ | ||
| sparse-checkout-cone-mode: false | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1.15.0 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
|
|
@@ -94,23 +94,23 @@ jobs: | |
| # isolation that flag buys is preserved exactly. | ||
| test_server: | ||
| name: Test Server ${{ matrix.shard }} | ||
| runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 | ||
| timeout-minutes: 10 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| shard: [1, 2, 3] | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
| !/.repos/ | ||
| sparse-checkout-cone-mode: false | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1.15.0 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
|
|
@@ -150,7 +150,7 @@ jobs: | |
|
|
||
| - name: Upload thread transfer result | ||
| if: always() && steps.transfer_budget.outputs.present == 'true' | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: thread-transfer-results | ||
| path: ${{ runner.temp }}/thread-transfer-result.json | ||
|
|
@@ -161,19 +161,19 @@ jobs: | |
| # for checks that take under 3s, on the critical path of every PR. | ||
| rust: | ||
| name: Rust | ||
| runs-on: ubuntu-24.04 # blacksmith-4vcpu-ubuntu-2404 | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
| !/.repos/ | ||
| sparse-checkout-cone-mode: false | ||
|
|
||
| - name: Setup Rust | ||
| uses: dtolnay/rust-toolchain@4360b52568e2003a75bf9bc1d59f33a8e3fc893c # stable | ||
|
There was a problem hiding this comment. Rust pin drops toolchain channelHigh Severity Pinning Additional Locations (2)  Reviewed by Cursor Bugbot for commit 1b32eb8. Configure here. |
||
| with: | ||
| components: rustfmt | ||
|
|
||
|
|
@@ -189,7 +189,7 @@ jobs: | |
| # the diff cannot be resolved, the lint runs. | ||
| mobile_native_changes: | ||
| name: Mobile Native Changes | ||
| runs-on: ubuntu-24.04 # blacksmith-2vcpu-ubuntu-2404 | ||
| timeout-minutes: 5 | ||
| permissions: | ||
| contents: read | ||
|
|
@@ -267,19 +267,19 @@ jobs: | |
| # Skip only on an explicit "no": a gate job that failed or errored leaves the | ||
| # output empty, and that must run the lint rather than silently skip it. | ||
| if: ${{ !cancelled() && needs.mobile_native_changes.outputs.changed != 'false' }} | ||
| runs-on: macos-26 # blacksmith-6vcpu-macos-26 | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
| !/.repos/ | ||
| sparse-checkout-cone-mode: false | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1.15.0 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
|
|
@@ -295,19 +295,19 @@ jobs: | |
|
|
||
| release_smoke: | ||
| name: Release Smoke | ||
| runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0 | ||
| with: | ||
| sparse-checkout: | | ||
| /* | ||
| !/.repos/ | ||
| sparse-checkout-cone-mode: false | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@250f29ce396baf5e8f24498e17c0dfdebabc26eb # v1.15.0 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust toolchain SHA pin is unsafe
Medium Severity
Pinning
dtolnay/rust-toolchainto astableref SHA without atoolchaininput is unsafe. That action force-pushesstable, so GitHub eventually garbage-collects the commit and the action cannot be resolved. The rust CI job, macOS preview, and release builds then fail, and there is norust-toolchain.tomlto fall back on.Additional Locations (2)
.github/workflows/desktop-macos-preview.yml#L65-L68.github/workflows/release.yml#L460-L463Reviewed by Cursor Bugbot for commit 496207d. Configure here.