Expose BERT token-type embeddings through TransformerBridge - #1664
Merged
jlarson4 merged 1 commit intoAug 13, 2026
Merged
Conversation
Collaborator
|
Looks great, thanks @LarryHu0217! |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose BERT token-type (segment) embeddings as the bridge-native
token_type_embed.hook_outhook.The BERT adapter now maps
bert.embeddings.token_type_embeddingsthrough anEmbeddingBridge. The regression test bootsbert-base-cased, captures the new hook withrun_with_cache, and compares it directly with Hugging Face's token-type embedding output.Fixes #1662
Type of change
Validation
uv run pytest tests/unit/model_bridge/supported_architectures/test_bert_adapter.py -q --tb=short -o addopts=: 22 passedmake unit-test: 5,260 passed, 56 skipped, 54 deselected, 10 xfailedmake check-format: passeduv run mypy .: no issues in 431 source filesmake docstring-test: 17 passed, 24 skippedmake acceptance-test: 199 passed, 72 skipped, 11 deselectedmake integration-test: 1,016 passed; the twogoogle/gemma-2-2b-itcases could not run locally because this machine is not authenticated for that gated Hugging Face model (401)Checklist