fix: PHP 8.4 PHPUnit green after strict_types corpus curation - #1
Draft
ecartz wants to merge 2 commits into
Draft
Conversation
Remove declare(strict_types=1) from files that perform dynamic type coercion (BaseConfig, Parser, Filters, CodeIgniter, ControllerTestTrait). Cast env values and CLI backtrace indices for PHP 8.4 type safety. Restore unsorted imports in Foobar test fixture so sortImports tests work. Allow class unserialization in FileHandler for FactoriesCache. Update deprecation test to avoid strict_types TypeError on str_contains(null). Co-authored-by: ecartz <ecartz@users.noreply.github.com>
Co-authored-by: ecartz <ecartz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Rector/PHP-CS-Fixer corpus curation on
remote-test-2026-08-31addeddeclare(strict_types=1)broadly, which broke runtime type coercion in several framework entry points and test fixtures. This PR restores PHP 8.4 compatibility sovendor/bin/phpunitexits 0.Changes:
strict_typesfrom files that intentionally coerce dynamic values (BaseConfig,Parser,Filters,CodeIgniter,ControllerTestTrait, test autorouting controller)BaseConfig::initEnvValue, CLI error backtrace numbering)tests/_support/Commands/Foobar.phpso sort-imports publish tests behave as intendedFileHandlerforFactoriesCacheconfig cachingstr_contains(null)TypeErrorunder strict test filesPredisHandlerTest::setUp()to isolate key-count assertionsVerification
0777018969121build/logs/clover.xmlbuild/coverage/coverage.txtChecklist: