fix: don't leak test tmp files into recent-files - #574
Open
azfoo wants to merge 1 commit into
Open
Conversation
use_test_settings was scope=module and only pulled in transitively via the qtui fixture, so backend-only tests (using just the tilia/tilia_state fixtures, no qtui) never redirected tilia.settings.settings to the test QSettings store. Any such test that opened/saved a file wrote its tmp_path straight into the developer's real "Desktop Settings" store, polluting the actual app's Open Recent menu. Make the fixture session-scoped and autouse so the redirect happens before any test touches settings, regardless of which other fixtures it requests.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_test_settings was scope=module and only pulled in transitively via the qtui fixture, so backend-only tests (using just the tilia/tilia_state fixtures, no qtui) never redirected tilia.settings.settings to the test QSettings store. Any such test that opened/saved a file wrote its tmp_path straight into the developer's real "Desktop Settings" store, polluting the actual app's Open Recent menu.
Make the fixture session-scoped and autouse so the redirect happens before any test touches settings, regardless of which other fixtures it requests.