You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This branch was cut ~209 commits before current dev and no longer merges — the TimelineKind enum it's written against has since been removed in favour of Timeline subclasses, and add.py was restructured around that.
Review also turned up that the audiowave kind could not have worked from the CLI at all: create_timeline calls AudioWaveTimeline.refresh(), which requests Get.PLAYBACK_AREA_WIDTH — served only by QtUI. With media loaded it raised NoReplyToRequest and left an empty timeline behind; without media it produced a hidden, empty one. The tests here passed because they never loaded media and asserted only kind and name, both of which hold for a hidden empty timeline.
#575 reimplements this on dev with that fixed, adds pdf so #476 actually closes, and rejects --height for harmony instead of silently dropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
harmony/harandaudiowave/audas valid kind arguments totimelines add.--heightkwarg (their height is computed from level count and level height internally).--height.Test plan
tilia timelines add harmony --name "Chords"creates a harmony timeline.tilia timelines add harworks as shorthand.tilia timelines add audiowave --name "Wave"creates an audiowave timeline.tilia timelines add audworks as shorthand.Closes #476