fix: use current measure number as initial value in set measure number dialog - #480
Draft
FelipeDefensor wants to merge 2 commits into
Draft
fix: use current measure number as initial value in set measure number dialog#480FelipeDefensor wants to merge 2 commits into
FelipeDefensor wants to merge 2 commits into
Conversation
FelipeDefensor
force-pushed
the
fix/471-measure-number-initial-value
branch
from
May 6, 2026 15:54
40b1efc to
d8b5045
Compare
Collaborator
Author
|
Add tests for this. |
Serve discards the arguments a request is made with, so the dialog itself has to be mocked to assert what it is prefilled with. Without that, the initial value could be dropped entirely or read from the wrong measure and the whole suite would stay green. Also pins the multi-measure behaviour, which is easy to misread now that the dialog opens on an existing number: the initial value comes from the earliest selected measure, and accepting it sets every selected measure to that number.
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #471