Skip to content

Update sta ptr to 17a3cc8de for BFS chunking (OpenSTA#405) - #11243

Merged
maliberty merged 3 commits into
The-OpenROAD-Project:masterfrom
calewis:sta-chunking-bfs
Aug 27, 2026
Merged

Update sta ptr to 17a3cc8de for BFS chunking (OpenSTA#405)#11243
maliberty merged 3 commits into
The-OpenROAD-Project:masterfrom
calewis:sta-chunking-bfs

Conversation

@calewis

@calewis calewis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Bump OpenSTA submodule pointer to 17a3cc8def3d12d078ec58e7d072e3f618dccae5 to run OpenROAD CI and verify QoR neutrality for The-OpenROAD-Project/OpenSTA#405.

Bump OpenSTA submodule pointer to 17a3cc8def3d12d078ec58e7d072e3f618dccae5
to run OpenROAD CI and verify QoR neutrality for The-OpenROAD-Project/OpenSTA#405.

Signed-off-by: Drew Lewis <cannada@google.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the subproject commit reference for src/sta to a newer version. There are no review comments, and I have no feedback to provide.

@calewis

calewis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Code Review

This pull request updates the subproject commit reference for src/sta to a newer version. There are no review comments, and I have no feedback to provide.

@maliberty might want to disable the gemini review bot on draft PRs

@maliberty

Copy link
Copy Markdown
Member

@calewis I often like to fix the gemini feedback before marking the PR as ready for review. What is your concern?

@calewis

calewis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

@maliberty that's fine I guess. My concern was imagine I open a PR in draft form I know isn't good and I'm actively working on it, but maybe I want to use github to review my own changes. And Gemini is now sending me a bunch of feedback for things that are in flight.

@maliberty

Copy link
Copy Markdown
Member

By "github to review my own changes" are you talking about CoPilot?

@calewis

calewis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

No sometimes I just want to use the web interface to review my changes. That way you see them like a reviewer would see them.

Anyways I didn't realize you wanted the gemini review on drafts. I assumed it was just running on all PRs by default. If it was intentional please leave it.

@maliberty

Copy link
Copy Markdown
Member

If you just want to see the GH formatted diffs you don't need a PR, for example master...gadfort:OpenROAD:odb-diff

@calewis

calewis commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks

Bump OpenSTA submodule pointer to 65bd9df5f7846015313734d08a5a6367df79453c,
the squashed revision of The-OpenROAD-Project/OpenSTA#405 after review,
to re-run OpenROAD CI and verify QoR neutrality.

Signed-off-by: Drew Lewis <cannada@google.com>
Signed-off-by: Drew Lewis <cannada@google.com>
@dsengupta0628
dsengupta0628 marked this pull request as ready for review August 27, 2026 20:49
@dsengupta0628
dsengupta0628 requested a review from a team as a code owner August 27, 2026 20:49
@maliberty
maliberty merged commit 4218d14 into The-OpenROAD-Project:master Aug 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants