Skip to content

Fix text contrast in menu elements - #1098

Merged
SeanCassiere merged 1 commit into
TanStack:mainfrom
Nicolapps:nicolas/fix-navbar-text-color
Aug 5, 2026
Merged

Fix text contrast in menu elements#1098
SeanCassiere merged 1 commit into
TanStack:mainfrom
Nicolapps:nicolas/fix-navbar-text-color

Conversation

@Nicolapps

@Nicolapps Nicolapps commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Before

Screenshot 2026-08-02 at 13 59 57 Screenshot 2026-08-02 at 13 59 53 Screenshot 2026-08-02 at 13 59 48 Screenshot 2026-08-02 at 13 59 43 image

After

Screenshot 2026-08-02 at 14 01 53 Screenshot 2026-08-02 at 14 01 50 Screenshot 2026-08-02 at 14 01 47 image image

Summary by CodeRabbit

  • Style
    • Improved mega-menu text colors across mobile and desktop layouts.
    • Enhanced label contrast in light and dark modes.
    • Updated the desktop partner rail title color for better visual consistency.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60abe856-a707-4b7a-b3ee-05187240e459

📥 Commits

Reviewing files that changed from the base of the PR and between 549af86 and 1f29057.

📒 Files selected for processing (2)
  • src/components/MegaMenuItem.tsx
  • src/components/Navbar.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/components/MegaMenuItem.tsx
  • src/components/Navbar.tsx

📝 Walkthrough

Walkthrough

The changes update navigation text colors for mobile and desktop variants, light and dark modes, and the desktop partner rail.

Changes

Navigation color variants

Layer / File(s) Summary
Mega-menu color variants
src/components/MegaMenuItem.tsx, src/components/Navbar.tsx
Mega-menu item titles and section headings now use responsive variant-specific text colors.
Navbar heading colors
src/components/Navbar.tsx
Blog headings and the desktop partner rail title now use updated light/dark-mode color variants.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: improving text contrast in navigation menu elements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SeanCassiere
SeanCassiere force-pushed the nicolas/fix-navbar-text-color branch from f25dfaa to 1f29057 Compare August 5, 2026 20:34
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@SeanCassiere
SeanCassiere merged commit 69ed02d into TanStack:main Aug 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants