Skip to content

App and tool updates for multi-binary support - #46

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
manifest-v3
Sep 9, 2026
Merged

App and tool updates for multi-binary support#46
KenVanHoeylandt merged 3 commits into
mainfrom
manifest-v3

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
  • implement CoreUtils as test project to expand upon later

Summary by CodeRabbit

  • New Features

    • Added hidden CoreUtils utilities for displaying the current date/time and echoing command-line text.
    • Added support for packaging multiple applications within a single app bundle.
  • Improvements

    • Updated the build tool with a structured command-line interface, semantic version checks, and compatibility support for manifest formats 0.2 and 0.3.
    • Build, install, run, and uninstall workflows now provide improved validation and package handling.
    • Existing applications were updated for the latest manifest format and application launch behavior.

+ implement CoreUtils as test project to expand upon later
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 592db142-367b-4605-9a04-2a9555a5574a

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea4626 and bea1e7a.

📒 Files selected for processing (22)
  • .github/actions/build-app/action.yml
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/manifest.properties
  • Apps/Calculator/manifest.properties
  • Apps/CoreUtils/manifest.properties
  • Apps/Diceware/manifest.properties
  • Apps/Doom/manifest.properties
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/manifest.properties
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/manifest.properties
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/manifest.properties
  • release.py
📝 Walkthrough

Walkthrough

The pull request migrates application manifests to version 0.3 and updates the build tool for multiple binaries, package archives, semantic version checks, and flag-based commands. Existing applications use shorter CMake project identifiers and the app_start_for_result APIs. The CoreUtils bundle adds echo and date applications with CMake configurations and manifest metadata.

Priority: ➖ Normal

Merge Risk: 🟠 High · up to 8ea46

The migrated packages cannot be reliably installed or processed by the release workflow, so the primary packaging flow should be corrected before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 7.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 69 functions across 14 files. (43 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: updates to apps and build tools to support multiple binaries. It is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 7.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 69 functions across 14 files. (43 skipped: 43 unsupported.)

✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch manifest-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7a84f423-fd11-4a9a-848d-aa097fe4f832

📥 Commits

Reviewing files that changed from the base of the PR and between 59da44e and 8ea4626.

📒 Files selected for processing (57)
  • Apps/Brainfuck/CMakeLists.txt
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/CMakeLists.txt
  • Apps/Breakout/manifest.properties
  • Apps/Calculator/CMakeLists.txt
  • Apps/Calculator/manifest.properties
  • Apps/CoreUtils/date/CMakeLists.txt
  • Apps/CoreUtils/date/main/CMakeLists.txt
  • Apps/CoreUtils/date/main/Source/main.c
  • Apps/CoreUtils/echo/CMakeLists.txt
  • Apps/CoreUtils/echo/main/CMakeLists.txt
  • Apps/CoreUtils/echo/main/Source/main.c
  • Apps/CoreUtils/manifest.properties
  • Apps/Diceware/CMakeLists.txt
  • Apps/Diceware/main/Source/Diceware.cpp
  • Apps/Diceware/manifest.properties
  • Apps/Doom/CMakeLists.txt
  • Apps/Doom/main/Source/main.cpp
  • Apps/Doom/manifest.properties
  • Apps/EpubReader/CMakeLists.txt
  • Apps/EpubReader/main/Source/EpubReader.cpp
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/CMakeLists.txt
  • Apps/EspNowBridge/main/Source/EspNowBridge.cpp
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/CMakeLists.txt
  • Apps/GPIO/manifest.properties
  • Apps/GraphicsDemo/CMakeLists.txt
  • Apps/GraphicsDemo/main/Source/Main.cpp
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/CMakeLists.txt
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/CMakeLists.txt
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/CMakeLists.txt
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/CMakeLists.txt
  • Apps/MediaKeys/manifest.properties
  • Apps/MystifyDemo/CMakeLists.txt
  • Apps/MystifyDemo/main/Source/Main.cpp
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/CMakeLists.txt
  • Apps/SerialConsole/main/Source/ConnectView.cpp
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/CMakeLists.txt
  • Apps/Snake/main/Source/Snake.cpp
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/CMakeLists.txt
  • Apps/TamaTac/main/Source/TamaTac.cpp
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/CMakeLists.txt
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/CMakeLists.txt
  • Apps/TwoEleven/main/Source/TwoEleven.cpp
  • Apps/TwoEleven/manifest.properties
  • Tools/bump-versions.py
  • tactility.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Apps/CoreUtils/date/main/Source/main.c
Comment thread tactility.py
Comment thread tactility.py
Comment thread tactility.py
@KenVanHoeylandt
KenVanHoeylandt merged commit bf6c1c3 into main Sep 9, 2026
22 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the manifest-v3 branch September 9, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant