ESP-IDF v6.1 by KenVanHoeylandt · Pull Request #649 · TactilityProject/Tactility

KenVanHoeylandt · 2026-09-10T15:59:11Z

Summary by CodeRabbit

New Features
- USB mass-storage startup failures now display a clear reason on the boot screen.
- USB device and storage errors are available through public status APIs.
- Improved ESP32-P4 compatibility, including camera, Wi-Fi, Bluetooth, and USB support.
Improvements
- Updated display and touch drivers for newer hardware interfaces and color formats.
- Improved directory creation when multiple tasks access the same path.
- Enhanced RGB display configuration and GPIO handling.
Bug Fixes
- Corrected USB initialization cleanup and failure reporting.
- Improved compatibility across supported ESP32 devices and display panels.

+ add error screen for usb mount failure at boot

coderabbitai · 2026-09-10T15:59:31Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 534f0600-6d55-41ea-9a75-83e58a20ba72

📥 Commits

Reviewing files that changed from the base of the PR and between 4022f20 and 2cf8bea.

📒 Files selected for processing (6)

Devices/m5stack-tab5/device.properties
Platforms/platform-esp32/CMakeLists.txt
Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp
Platforms/platform-esp32/source/drivers/esp32_wifi.cpp
Tactility/idf_component.yml
device.py

🚧 Files skipped from review as they are similar to previous changes (2)

Platforms/platform-esp32/source/drivers/esp32_wifi.cpp
Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

The change migrates platform code to ESP-IDF 6.1. It updates display and I2C drivers, TinyUSB storage, cryptography, Bluetooth, C/C++ symbol exports, ESP32 configuration, build actions, and device properties. It adds USB failure propagation to the boot interface, updates filesystem race handling, and adjusts ESP32-P4 compatibility and linker configuration.

Priority: ➖ Normal

Merge Risk: 🟡 Moderate · up to 2cf8b

Affected display targets may not build, while some USB and accelerated-display startup failures can be hidden or reported incorrectly. These issues should be resolved before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.30% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 94 functions across 50 files. (3 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: upgrading the project to ESP-IDF v6.1. It is concise and directly related to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 38.30% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 94 functions across 50 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch idf-6.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

Drivers/ili9881c-module/source/ili9881c.cpp (1)

238-238: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Migrate DMA2D enablement to the runtime panel API.

ESP-IDF v6.1 removes use_dma2d from esp_lcd_dpi_panel_config_t, so these designated initializers no longer compile. Remove .use_dma2d from all three configurations. When config->use_dma2d is true, call esp_lcd_dpi_panel_enable_dma2d(internal->panel_handle) after panel creation and handle a non-ESP_OK result as panel-start failure.

Platforms/platform-esp32/source/drivers/esp32_wifi.cpp (1)

84-84: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not map unsupported authentication modes to open authentication.

ESP-IDF 6.1 replaces the removed external-PSK values with WIFI_AUTH_DUMMY_1 and WIFI_AUTH_DUMMY_2. It also defines WIFI_AUTH_UNKNOWN for invalid or unparseable scan records. api_get_scan_results() passes these values to to_wifi_authentication_type(), whose default branch reports them as WIFI_AUTHENTICATION_TYPE_OPEN. Preserve a distinct WPA3 or unsupported result.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7320c46f-64fa-4081-b9f3-79ddbc047ce3

📥 Commits

Reviewing files that changed from the base of the PR and between 8556103 and d9399e3.

📒 Files selected for processing (55)

Devices/lilygo-tdeck/lilygo,tdeck.dts
Devices/lilygo-tdisplay-s3/CMakeLists.txt
Devices/m5stack-stickc-plus2/CMakeLists.txt
Drivers/cst816s-module/source/cst816s.cpp
Drivers/ft5x06-module/source/ft5x06.cpp
Drivers/ft6x36-module/source/ft6x36.cpp
Drivers/gc9a01-module/source/gc9a01.cpp
Drivers/gt911-module/source/gt911.cpp
Drivers/ili9341-module/source/ili9341.cpp
Drivers/ili9488-module/source/ili9488.cpp
Drivers/ili9881c-module/source/ili9881c.cpp
Drivers/jd9165-module/source/jd9165.cpp
Drivers/jd9853-module/source/esp_lcd_jd9853.c
Drivers/jd9853-module/source/jd9853.cpp
Drivers/lilygo-module/CMakeLists.txt
Drivers/rgb-display-module/source/rgb_display.cpp
Drivers/ssd1306-module/source/ssd1306.cpp
Drivers/st7121-module/source/st7121.cpp
Drivers/st7123-module/source/st7123.cpp
Drivers/st7123-module/source/st7123_touch.cpp
Drivers/st7701-module/source/st7701.cpp
Drivers/st7735-module/source/st7735.cpp
Drivers/st7789-i8080-module/source/st7789_i8080.cpp
Drivers/st7789-module/source/st7789.cpp
Drivers/st7796-i8080-module/source/st7796_i8080.cpp
Drivers/st7796-module/source/st7796.cpp
Libraries/QRCode/src/qrcode.h
Libraries/mbedtls
Modules/crypt-module/CMakeLists.txt
Modules/crypt-module/source/crypt.cpp
Modules/mbedtls-module/source/module.cpp
Platforms/platform-esp32/CMakeLists.txt
Platforms/platform-esp32/include/tactility/drivers/esp32_esp_hosted_ota.h
Platforms/platform-esp32/include/tactility/drivers/esp32_i2s.h
Platforms/platform-esp32/source/drivers/esp32_esp_hosted_ota.cpp
Platforms/platform-esp32/source/drivers/esp32_i8080.cpp
Platforms/platform-esp32/source/drivers/esp32_wifi.cpp
Platforms/platform-esp32/source/drivers/usb/esp32_usb_cdc_device.cpp
Platforms/platform-esp32/source/drivers/usb/esp32_usb_device_controller.cpp
Platforms/platform-esp32/source/drivers/usb/esp32_usb_device_msc.cpp
Tactility/CMakeLists.txt
Tactility/Include/Tactility/hal/usb/Usb.h
Tactility/Private/Tactility/hal/usb/UsbTusb.h
Tactility/Source/app/apphub/AppHubApp.cpp
Tactility/Source/app/boot/Boot.cpp
Tactility/Source/file/File.cpp
Tactility/Source/hal/usb/Usb.cpp
Tactility/Source/hal/usb/UsbMock.cpp
Tactility/Source/hal/usb/UsbTusb.cpp
Tactility/Source/service/espnow/EspNowBackendHosted.cpp
Tactility/Source/service/espnow/EspNowBackendNative.cpp
Tactility/idf_component.yml
TactilityKernel/include/tactility/drivers/usb_device_controller.h
TactilityKernel/include/tactility/drivers/usb_msc_device.h
device.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

coderabbitai

Actionable comments posted: 4

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: aaefe23f-dece-419a-b071-5932ecd4c232

📥 Commits

Reviewing files that changed from the base of the PR and between 026532b and 15735af.

⛔ Files ignored due to path filters (9)

partitions-16mb-no-sd-dev.csv is excluded by !**/*.csv
partitions-16mb-no-sd.csv is excluded by !**/*.csv
partitions-16mb-with-sd.csv is excluded by !**/*.csv
partitions-32mb-no-sd-dev.csv is excluded by !**/*.csv
partitions-32mb-no-sd.csv is excluded by !**/*.csv
partitions-4mb-with-sd.csv is excluded by !**/*.csv
partitions-8mb-no-sd-dev.csv is excluded by !**/*.csv
partitions-8mb-no-sd.csv is excluded by !**/*.csv
partitions-8mb-with-sd.csv is excluded by !**/*.csv

📒 Files selected for processing (20)

Devices/m5stack-tab5/device.properties
Drivers/ili9881c-module/source/ili9881c.cpp
Drivers/jd9165-module/source/jd9165.cpp
Drivers/st7121-module/source/st7121.cpp
Drivers/st7123-module/source/st7123.cpp
Modules/c-symbols-module/source/module.cpp
Modules/cpp-symbols-module/README.md
Modules/cpp-symbols-module/source/module.cpp
Platforms/platform-esp32/CMakeLists.txt
Platforms/platform-esp32/include/tactility/drivers/esp32_esp_hosted_ota.h
Platforms/platform-esp32/private/bluetooth/esp32_ble_internal.h
Platforms/platform-esp32/source/drivers/bluetooth/ble_hci_gate.c
Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp
Platforms/platform-esp32/source/drivers/esp32_esp_hosted_ota.cpp
Platforms/platform-esp32/source/drivers/esp32_wifi.cpp
Platforms/platform-esp32/source/drivers/esp32p4_libc_compat.c
Tactility/Source/service/espnow/EspNowBackendHosted.cpp
Tactility/Source/service/espnow/EspNowBackendNative.cpp
Tactility/idf_component.yml
device.py

💤 Files with no reviewable changes (2)

Platforms/platform-esp32/private/bluetooth/esp32_ble_internal.h
Platforms/platform-esp32/source/drivers/bluetooth/ble_hci_gate.c

🚧 Files skipped from review as they are similar to previous changes (1)

Platforms/platform-esp32/include/tactility/drivers/esp32_esp_hosted_ota.h

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

+ remove old i2c driver for esp32

Fully declare Module struct

Use new API

KenVanHoeylandt added 4 commits September 9, 2026 21:49

Update esp_tinyusb to v2.2.1

3d71ba5

+ add error screen for usb mount failure at boot

idf 6.1 initial updates for T-Deck

5d2ca31

Driver migrations

4cb0882

Fix for findOrCreateDirectoryInternal()

d9399e3

Update SDK in GitHub Actions

026532b

coderabbitai Bot reviewed Sep 10, 2026

View reviewed changes

Fixes

15735af

coderabbitai Bot reviewed Sep 10, 2026

View reviewed changes

Comment thread Drivers/jd9165-module/source/jd9165.cpp

Comment thread Drivers/st7121-module/source/st7121.cpp

Comment thread Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp Outdated

Comment thread Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp Outdated

KenVanHoeylandt added 21 commits September 11, 2026 15:26

Fixes

4022f20

esp_hosted downgrade

2cf8bea

Revert

a448052

Fix for download function

1d6bec2

Fix for wifi (revert)

41f9bf8

Fix callstack size (overflow on Cardputer)

34ca025

runAutoStart() on a separate IRAM task

cc7eec3

Merge branch 'main' into idf-6.1

66e8094

i2c driver migrations

4ca92b6

+ remove old i2c driver for esp32

Update AppManifest to fix warnings

43d9910

Fix for Module warnings

e893000

Fully declare Module struct

Fixed warnings

8558033

Minimal buffer

713511c

Merge branch 'main' into idf-6.1

362e6de

Fixed warnings

96debde

Fix for warning in GT911

365641e

Use new API

Fix warning

bcd6413

Free up IRAM

69ee4b5

Remove unused i2c headers in dts files

a5cc77b

Fix for wifi mode changes while wifi is already active

fea8df7

Fix for Setup app not showing

0cce7e0

Driver updates

3e9f0fb

KenVanHoeylandt merged commit 0ee725e into main Sep 12, 2026
64 checks passed

KenVanHoeylandt deleted the idf-6.1 branch September 12, 2026 22:52

Navigation Menu

Uh oh!

Uh oh!

ESP-IDF v6.1 - #649

ESP-IDF v6.1#649
KenVanHoeylandt merged 28 commits into
mainfrom
idf-6.1

KenVanHoeylandt commented Sep 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

Reviews paused

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

KenVanHoeylandt commented Sep 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

KenVanHoeylandt commented Sep 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading