fix(showcase): street-lantern and water-trough visual quality pass - #181
Merged
Merged
Conversation
Seat the hanger on a closed square pyramid and lock brace/hanger contact as BVH budgets so a welded cone stack cannot regress. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Rebuild the hull as U-staves and U-caps on one radius so box-slab ends and through-leg stretchers cannot pass. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Record coplanar-vs-weld seating so future pieces inherit a named overlap or rebate instead of coincident faces. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual quality pass on
street-lanternandwater-trough. Both were budget-green assemblies that did not read as the objects they claim to be. Generators were rebuilt structurally (shared planes/radii, named overlap/rebate) and the new hygiene/joint budgets were locked with falsifiers proven on 4.5.11, 5.1.2, and 5.2.1.Picks: the two remaining complex assemblies whose gallery witnesses still only mentioned
--skip-decimate.street-lantern
Defects (view that revealed each)
create_conecap centres shared one vertex at the post top, collapsing three parts into one shell. Arm-root close-up + clay.Generator changes (structural)
cage_top - 0.001. Apex is a function of that plane; finial cones sit on the apex; metal stub runs fromapex + 0.70 * FINIAL_Hinto the arm underside.hang_zis always post top. Arm Z is independent so--sink-armcan drop the arm without dragging the cage.post_radius_at(arm_z) - 0.008; brass skirt lifted off the post bottom so cap centres cannot weld.CAGE_JOINToverlap; muntins split around the mid rail. Glass inset byPANE_REBATE.STEP_SINKso the two boxes do not share a coplanar face.remove_doubles+dissolve_degenerateafter bevel; n-gons triangulated.Hygiene (measured 4.5.11 / 5.1.2 / 5.2.1)
Exit codes (all three binaries)
--skip-decimate--stray-vert--lift-z--float-brace--sink-arm--rake-postTris / rounds
3520 → 3338. Collider 84 → 78. Inspection rounds: 3.
Hero on 5.2.1:
check_framingfill 0.711, min margin 0.072. Nodeviation=.water-trough
Defects (view that revealed each)
LEG_X— trestle legs punched through the iron. Side ortho + strap-leg close-up.Generator changes (structural)
sin(i)width jitter. End caps areadd_u_shellboards the staves tenon into.STRAP_X = TRAY_L * 0.18, offset fromLEG_X = TRAY_L * 0.28. Strap inner radius is host outer minusSTRAP_BITE.y_legis a lerp of the leg stations; length is2*(y_leg - 0.022), not through-volume.add_u_waterfrom inside the left cap thickness to inside the right.STAVE_T * 0.35into the hull along the leg direction. Shoes at Z=0.--short-legslifts shoes only so AABB zmin stays 0 and the named-support gate fires.--box-endsadds a subdivided slab after bevel so rim-span 17 fires without killing wood verts.--narrow-hullis not swallowed by a moved box.Hygiene (measured 4.5.11 / 5.1.2 / 5.2.1)
Exit codes (all three binaries)
--skip-decimate--stray-vert--lift-z--short-legs--box-ends--float-strap--narrow-hullTris / rounds
2484 → 3700. Collider 32 → 64. Inspection rounds: 3. Remaining nit: ~1 mm water/end-cap slit at the rim (water_gap 2.6 mm, under budget).
Hero on 5.2.1:
check_framingfill 0.794, min margin 0.044. Nodeviation=.Convention
showcase/README.mdnow states the designed-overlap rule: coplanar faces z-fight, shared vertices weld; seat with a named overlap/rebate from the host; hang-station vs arm-station so a contact falsifier can move one member.Evidence
Live headless runs on
.scratch/blender-4.5.11-windows-x64,.scratch/blender-5.1.2-windows-x64,.scratch/blender-5.2.1-windows-x64(binary-reported versions). Inspection sheets in.scratch/(untracked). Gallery HTML alts and witnesses read back afterscripts/build_gallery.py.Test plan
blender-smoke5.2 LTS greenblender-smoke4.5 LTS greenblender-smoke5.1 (needs-5.1) green