fix(showcase): anvil and campfire visual quality pass - #178
Merged
Merged
Conversation
The old piece stacked beveled boxes with glued nubs as holes and a twisted horn. One slotted face, oval rings, and stave-chord hoops are durable; per-coordinate nudges are not. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
The old ring floated a mortar gap between identical boxes and ended the tripod at one point. Shared-Z courses and an overshooting apex ring are durable; per-log coordinate nudges are not. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual quality pass on anvil and campfire — the two remaining pieces that had never had one. Three inspection rounds on 5.2.1. Fixes are in the generators. Hygiene 15–19 already live in
showcase/README.md; this PR does not change that file.Picks: never-passed. Next run should take market-stall / watchtower (largest remaining unpassed silhouettes).
Anvil
Defects (inspection sheet, rounds 1–2)
Round 3: horn is an oval cone, hardy and pritchel are through-holes in one slab, stump/hoops/waist/foot seated. Face is still a razor-edged London bar (no iron bevel); that is remaining polish, not a budget fail.
Structural fixes
add_slotted_slabfor the face (grid around two hole cells) instead of welded boxes.N_SECTIONparameterization — no superellipse morph.host_outer_rstave chords;--round-banduses a circle.--float-anvillifts the iron 10 mm so bbox 8 still passes and 17 fires.deviation=).Budgets (4.5.11 / 5.1.2 / 5.2.1)
--skip-decimate--stray-vert--lift-z--short-staves--float-anvil--round-bandInspection rounds: 3. Framing on 5.2.1: fill y=0.800, margins ok. No
deviation=.Campfire
Defects (inspection sheet, rounds 1–2)
Round 3: courses share Z, teepee crosses at the apex, ash fills the pit, 14 wedges grounded. Stones still read as bricks more than cobbles; silhouette is a campfire.
Structural fixes
row * STONE_H(shared plane).--gap-coursesinsertsCOURSE_GAP.(STICK_R * 0.55) / sin(π/N)plus overshoot past the kiss point.--float-logsinflates the ring.GAP_ANG0.004 from the span function, not per-stone nudges.remove_doublesafter bevel.deviation=).Budgets (4.5.11 / 5.1.2 / 5.2.1)
--skip-decimate--stray-vert--lift-z--short-stones--float-logs--gap-coursesInspection rounds: 3. Framing on 5.2.1: fill y=0.733, bottom margin 0.033. No
deviation=.Evidence
.scratch/blender-4.5.11-windows-x64,blender-5.1.2-windows-x64,blender-5.2.1-windows-x64(binaries self-report those versions). Hero stills Cycles 5.2.1. Generated HTML alts/witnesses read back afterpython scripts/build_gallery.py..scratch/qpass/(untracked).gallery_framing.py, LICENSE, VERSION, CHANGELOG, release/smoke/pages workflows.Test plan
needs-5.1labeled; 5.1 smoke greenMade with Cursor