fix(showcase): wooden-barrel and wooden-bucket visual quality pass - #177
Merged
Merged
Conversation
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Showcase visual quality pass on wooden-barrel and wooden-bucket (never passed; last report's remaining stave/hoop CG class). Round-1 inspection confirmed 12-gon identical staves, circular hoops floating off flats, circular heads leaving slots in the polygonal croze, a 12-box rope bail that never entered the ear rings, and ear cubes punching through the rim.
Both generators were rewritten so hoops, heads, and ears evaluate the same stave-chord host. Hygiene 15–19 locked. Inspection sheets stayed in
.scratch/(untracked).wooden-barrel
Defects (round 1, every inspect view)
Structural fixes
GAP_Mhost_outer_rchord formula; hoops lofted on stave faces with bite/proud/chamfer (--round-bandis a circle ofradius_at(z))croze_xy, recessed byCHIMEso stave ends stand above the lid--short-staves); head-croze gap (--float-head)Hygiene (measured 4.5.11 / 5.1.2 / 5.2.1)
Falsifiers (same code on all three binaries)
--skip-decimate--stray-vert--lift-z/--short-staves--float-head--round-bandFraming gate passed on 5.2.1 (fill y=0.822, margins ≥ 0.056). 3 inspection rounds.
wooden-bucket
Defects (round 1)
STAVE_GAP=-0.08) — joint-stave, wireStructural fixes
--float-bottom)host_outer_r + plate_t/2, top below the rim; flat XY rings; round semicircle bail through the rings (--float-handleshrinks rx)bail_joinis min nearest distance from ring verts to bail BVHHygiene (all three binaries)
Falsifiers (same code on all three)
--skip-decimate--stray-vert--lift-z/--short-staves--float-handle/--float-bottom--round-bandFraming gate passed on 5.2.1 (fill y=0.733, margins ≥ 0.083). 3 inspection rounds.
Test plan
blender-smoke5.2 LTS and 4.5 LTS green on this headneeds-5.1labeled via REST; 5.1 smoke job appears and is green--adminshowcase/README.mdconventions (hygiene 15–19, named supports,--round-bandseat) were already in place — no convention commit.