fix(showcase): treasure-chest and tavern-stool visual quality pass - #175
Merged
Merged
Conversation
…uckles Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Showcase visual quality pass on treasure-chest and tavern-stool (the two worst remaining from the grindstone/wheelbarrow report). Generators rebuilt; hygiene/joint-fit locked as assertions; heroes re-rendered on 5.2.1 with
check_framing(nodeviation=).treasure-chest
Intended size: 0.74 × 0.46 m plan, ~0.35 m to the rim, barrel-vault lid. AABB (0.764, 0.542, 0.691) m.
Defects (inspection sheet,
.scratch/qpass/chest/)Generator fixes (structural)
add_arc_slabbarrel vault (not stacked boxes). Overlay slat ribs were dropped after clay_side showed them as a comb.material_index).--float-hingelifts knuckles off barrels without swinging the vault past the AABB.Hygiene / joint-fit (all three binaries)
Falsifiers (same on 4.5.11, 5.1.2, 5.2.1): default 0;
--skip-decimate9;--stray-vert15;--lift-z16;--short-legs16;--float-hinge17;--narrow-bands18.Inspection rounds: 4 generator looks (round-1 original; round-2 rewrite; round-3 vault biscuits; round-4 lofted slab). Framing on 5.2.1: fill y=0.756, margins ok.
Remaining nits (not blocking): lid straps still faceted along the arc; lock staple is two nubs; hinge barrels are boxes; feet are beveled cubes.
tavern-stool
Intended size: 0.34 m seat, 0.47 m high, splayed legs. AABB (0.340, 0.340, 0.470) m.
Defects
--float-stretcherscould not fail — stretcher_join.Generator fixes (structural)
--float-stretchersomits the rails (named fail 17);--pipe-ferruleis a torus in the bite band.Hygiene / joint-fit (all three)
Falsifiers (same on all three): default 0;
--skip-decimate9;--stray-vert15;--lift-z16;--short-legs16;--float-stretchers17;--pipe-ferrule18.Inspection rounds: 3 (original / rewrite / 48-seg + clearance). Framing on 5.2.1: fill y=0.794, margins ok.
Remaining nits: vertical cup vs splay still shows a crescent of daylight in the close-up; seat rim still a 48-gon if you look.
Test plan
deviation=)