feat: enforce framing deviation at the call site - #149
Merged
Merged
Conversation
check_framing no longer accepts deviation=. measure_framing_deviation returns the score so bleed compositions fail at the call site. modular-kit-snap asserts a projection fill-over cap; socket-attach-points drops the flag and leaves --falsify unenforced. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measure_framing_deviation(scene, camera, ...) -> (FramingResult, score).check_framingstill returns0/10. Not an extra return oncheck_framing— ~24 callers dofcode = check_framing(...)and treat it as an int.deviation=. Helper always enforces Layer 1. Call sites that own bleed assert their own cap.modular-kit-snap: projection fill-over capFRAME_DEV_MAX = 8.0. Gallery camera score 5.0584 (pass).--close-camerascore 30.9012, exit 10. README exit table includes 10. Existing--falsifystill exits 0.socket-attach-points: dropdeviation=. Gallery--outputstill usescheck_framing(Layer 1).--falsifymeasures and prints, does not return 10 — otherwise the diagnostic would fail as a framing violation (margins touch right/top).--falsify/--probestill exit 0.check_framingcall sites are untouched (git diffnames only the two examples + the helper).Stop condition did not fire: default
--outputstays under the cap on all three binaries.Live-run evidence
Binaries (path → self-reported version):
.scratch/blender-4.5.11-windows-x64/blender.exe4.5.11 LTS(4db51e9d1e1e).scratch/blender-5.1.2-windows-x64/blender.exe5.1.2(ec6e62d40fa9).scratch/blender-5.2.1-windows-x64/blender.exe5.2.1 LTS(9e2066aef7ef)modular-kit-snap:--output(score 5.0584)--output --close-camera(score 30.9012)--falsifysocket-attach-pointson 5.2.1:--probe0,--falsify0 (framing printed as FAIL on margins; not enforced).Inspection only: generated gallery HTML alts for both detail pages (
modular-kit-snap render/socket-attach-points render); card alts ondocs/gallery/index.htmlunchanged.Test plan
needs-5.1via REST)