Skip to content

fix: PS7 double-install, false hostname failure; WinUtil Standard preset - #51

Merged
Stensel8 merged 1 commit into
mainfrom
Win-11-bugfixes
Sep 3, 2026
Merged

fix: PS7 double-install, false hostname failure; WinUtil Standard preset#51
Stensel8 merged 1 commit into
mainfrom
Win-11-bugfixes

Conversation

@Stensel8

@Stensel8 Stensel8 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Start.ps1: poll up to 20s (and log winget's exit code) after installing PowerShell 7 via WinGet instead of a single check 5s later, so a slow-to-register install isn't mistaken for a failure that then also triggers the MSI fallback, installing PowerShell 7 twice.
  • Set-HostName.ps1: exit 0 (not 1) when no valid BIOS serial number is found. That's an expected, already-handled case (common on VMs), not a failure - it was making Deploy.ps1 report "Some deployment steps failed" on otherwise-clean runs.
  • Deploy.ps1 / Apply-Tweaks.ps1: -Tweaks now defaults to Yes (including under -NonInteractive), so the WinUtil Standard preset just runs instead of requiring an explicit opt-in. -Tweaks No still skips it.
  • README: drop the "Option 3" windeploy.stensel.nl one-liner - it pointed at the pre-migration repo and isn't part of this one.
  • Docs and changelog updated to match.

Type of change

  • feat — new feature or script
  • fix — bug fix

PR title and commit types must follow these standards — view the contributing guide

Checklist

  • PR title follows the commit convention
  • Tested on a real Windows 11 25H2 machine (required for anything under Scripts/ or Docs/ — CI cannot exercise BitLocker, Sysprep, WinGet or Defender)
  • PSScriptAnalyzer passes locally
  • No hardcoded IPs, credentials, or company-specific data
  • Both EN (*.md) and NL (*.nl.md) versions updated, if src/content/ changed
  • No broken internal links, if src/ changed
  • Site tested locally with cd src && hugo server, if src/ changed

Notes

…s by default

- Start.ps1: poll up to 20s (and log winget's exit code) after installing
  PowerShell 7 via WinGet instead of a single check 5s later, so a
  slow-to-register install isn't mistaken for a failure that then also
  triggers the MSI fallback, installing PowerShell 7 twice.
- Set-HostName.ps1: exit 0 (not 1) when no valid BIOS serial number is
  found. That's an expected, already-handled case (common on VMs), not a
  failure - it was making Deploy.ps1 report "Some deployment steps failed"
  on otherwise-clean runs.
- Deploy.ps1 / Apply-Tweaks.ps1: -Tweaks now defaults to Yes (including
  under -NonInteractive), so the WinUtil Standard preset just runs instead
  of requiring an explicit opt-in. -Tweaks No still skips it.
- README: drop the "Option 3" windeploy.stensel.nl one-liner - it pointed
  at the pre-migration repo and isn't part of this one.
- Docs and changelog updated to match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AsMBvgEn1Zd9f2dneJDJWf
Copilot AI lite review requested due to automatic review settings September 3, 2026 12:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Stensel8 Stensel8 self-assigned this Sep 3, 2026
@Stensel8
Stensel8 merged commit 3ebee4b into main Sep 3, 2026
9 of 11 checks passed
@Stensel8
Stensel8 deleted the Win-11-bugfixes branch September 3, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants