fix: PS7 double-install, false hostname failure; WinUtil Standard preset - #51
Merged
Conversation
…s by default - Start.ps1: poll up to 20s (and log winget's exit code) after installing PowerShell 7 via WinGet instead of a single check 5s later, so a slow-to-register install isn't mistaken for a failure that then also triggers the MSI fallback, installing PowerShell 7 twice. - Set-HostName.ps1: exit 0 (not 1) when no valid BIOS serial number is found. That's an expected, already-handled case (common on VMs), not a failure - it was making Deploy.ps1 report "Some deployment steps failed" on otherwise-clean runs. - Deploy.ps1 / Apply-Tweaks.ps1: -Tweaks now defaults to Yes (including under -NonInteractive), so the WinUtil Standard preset just runs instead of requiring an explicit opt-in. -Tweaks No still skips it. - README: drop the "Option 3" windeploy.stensel.nl one-liner - it pointed at the pre-migration repo and isn't part of this one. - Docs and changelog updated to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AsMBvgEn1Zd9f2dneJDJWf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
feat— new feature or scriptfix— bug fixChecklist
Scripts/orDocs/— CI cannot exercise BitLocker, Sysprep, WinGet or Defender)*.md) and NL (*.nl.md) versions updated, ifsrc/content/changedsrc/changedcd src && hugo server, ifsrc/changedNotes