Suppport IPv6 and dual-stack ADB server connections in ppadb - #121
Open
beshaya wants to merge 1 commit into
Open
Suppport IPv6 and dual-stack ADB server connections in ppadb#121beshaya wants to merge 1 commit into
beshaya wants to merge 1 commit into
Conversation
When forwarding the ADB server port (5037) through SSH tunnels or on IPv6-enabled hosts (e.g., Rodete), the daemon binds to IPv6 loopback (`::1:5037`). ppadb previously hardcoded `socket.AF_INET` (IPv4 only) and `127.0.0.1`, which caused connection attempts to fail with `[Errno 111] Connection refused`. This change: - Updates `ppadb.connection.Connection.connect()` to resolve the host via `socket.getaddrinfo()`, supporting both IPv6 and IPv4 sockets. - Updates default `Client` host to `'localhost'`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When forwarding the ADB server port (5037) through SSH tunnels or on IPv6-enabled hosts (e.g., Rodete), the daemon binds to IPv6 loopback (
::1:5037). ppadb previously hardcodedsocket.AF_INET(IPv4 only) and127.0.0.1, which caused connection attempts to fail with[Errno 111] Connection refused.This change:
ppadb.connection.Connection.connect()to resolve the host viasocket.getaddrinfo(), supporting both IPv6 and IPv4 sockets.Clienthost to'localhost'.