Add skip-to-main-content links - #78
Draft
jpagh wants to merge 2 commits into
Draft
Conversation
jpagh
marked this pull request as draft
September 5, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing
tabafter the page loads brings up this otherwise hidden link that skips straight to the content:I tested it, and the only page where it didn't work was on an address page, where the first tab took you right to the question and a second tab to the first field. This seems acceptable.
Edit: Upon further testing and investigation, I think this might need more discussion about what the ideal result looks like. Not only the address field, but other fields can be a higher priority for either first tab, or are pre-selected on screen load. Should the skip to content link ALWAYS be the first thing that tab goes to, even if that means changing it so the cursor is never pre-selecting a field? Or should we allow pre-selecting a field, and use the skip to content only on other pages? Should we instead, on interview screens, maybe always make the first tab skip to content (Question) by default? I think this is interesting, but requires more thought about the correct implementation.
Closes #36