Skip to content

fix: remove unsupported vanilla cfg parameter - #494

Open
primorLee wants to merge 1 commit into
Stability-AI:mainfrom
primorLee:codex/fix-vanilla-cfg-config
Open

fix: remove unsupported vanilla cfg parameter#494
primorLee wants to merge 1 commit into
Stability-AI:mainfrom
primorLee:codex/fix-vanilla-cfg-config

Conversation

@primorLee

Copy link
Copy Markdown

Fixes #221

Summary

  • Stop forwarding the obsolete dyn_thresh_config argument to VanillaCFG.
  • Add a focused regression test for the default sampling configuration.

Problem

The default SamplingParams select VanillaCFG, whose constructor only accepts scale. The inference API also supplied dyn_thresh_config, causing get_sampler_config(SamplingParams()) to raise TypeError before model inference began.

Validation

  • pytest -q tests/inference/test_inference.py -k default_sampling_params_build_a_vanilla_cfg_sampler1 passed, 72 deselected
  • python -m py_compile sgm/inference/api.py tests/inference/test_inference.py
  • git diff --check

The focused pytest used a local CPU dependency bootstrap for optional host dependencies. The full GPU/model suite was not run, and pre-commit was unavailable in the host environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VanillaCFG.__init__() got an unexpected keyword argument 'dyn_thresh_config'

1 participant