Skip to content

BED-9542: fix ghcr creds - #209

Merged
codemonkey2841 merged 1 commit into
mainfrom
fix/bed9542-fix-ghcr-creds
Sep 2, 2026
Merged

BED-9542: fix ghcr creds#209
codemonkey2841 merged 1 commit into
mainfrom
fix/bed9542-fix-ghcr-creds

Conversation

@codemonkey2841

@codemonkey2841 codemonkey2841 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The package was using a custom user and token (set in repo secrets) to push to ghcr. now that we're pushing this image to the same org (and not the old org) we can use the default wokflow token.

ref: BED-9542

Summary by CodeRabbit

  • Chores
    • Updated container publishing workflows to authenticate with the GitHub Actions actor and token.
    • Existing Azure Container Registry authentication remains unchanged.

The package was using a custom user and token (set in repo secrets) to
push to ghcr. now that we're pushing this image to the same org (and not
the old org) we can use the default wokflow token.

ref: BED-9542
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: d7bdab05-fe04-4d28-bc8a-d21801e2418c

📥 Commits

Reviewing files that changed from the base of the PR and between 76a42c5 and 7b5b286.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/publish.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The build and publish workflows now authenticate Docker with GHCR using github.actor and secrets.GITHUB_TOKEN. The ACR authentication in the publish workflow remains unchanged.

Changes

Container authentication

Layer / File(s) Summary
GHCR login credentials
.github/workflows/build.yml, .github/workflows/publish.yml
Both workflows replace secrets.GHCR_USER and secrets.PACKAGE_SCOPE with github.actor and secrets.GITHUB_TOKEN for GHCR authentication.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7b5b2

This PR switches image publishing to the repository’s default workflow token for the same organization. No actionable merge-blocking risk remains.

Suggested reviewers: strandutton

Poem

A rabbit logs in, quick and bright
With GitHub’s token set just right
GHCR opens its door
Secrets are needed no more
Build and publish hop into flight

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the issue and the main change: fixing GHCR credentials. It is concise and related to the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bed9542-fix-ghcr-creds

Comment @coderabbitai help to get the list of available commands.

@codemonkey2841
codemonkey2841 merged commit 0120871 into main Sep 2, 2026
10 checks passed
@codemonkey2841
codemonkey2841 deleted the fix/bed9542-fix-ghcr-creds branch September 2, 2026 15:56
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants