Fix Python cfg variants - #197
Merged
Merged
Conversation
2. Gate the datetime and large_string dtype surface in convert.rs
The feature-off gate definitions no longer re-list the unconditional variants. Those are declared once in the base invocation, each gate's feature-on definition appends only its own group, and the feature-off definition forwards the list unchanged. Declaration order is therefore the unconditional variants followed by the gated groups, which nothing in the crate relies on: PyArrowType is constructed, converted and passed by variant, never cast, ordered or indexed. The module comment, the macro docs and the minarrow dependency comment are cut back to the point.
pbower
added a commit
that referenced
this pull request
Sep 9, 2026
1. Generate PyArrowType through a feature-gated variant list 2. Gate the datetime and large_string dtype surface in convert.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.