Fix Bitmask::fill panicking on an UnsafeMut window - #196
Merged
Conversation
fill iterated the backing Buffer<u8> via IntoIterator for &mut Buffer<u8>, which re-owns the buffer through make_owned_mut and panics for an UnsafeMut window. SIMD arithmetic kernels call fill on an output null mask that the orchestrator supplies as an UnsafeMut window, so any element-wise arithmetic on a nullable column aborted the process. Write through as_mut_slice instead, which already handles UnsafeMut by returning the borrowed window in place.
The $v:expr arm matched &[200] before the &[$($x:expr),+] arm could, routing through .into() which fails when Vec64 lacks From<&[T; N]>. Moving the specific arms first matches the pattern used by arr_f64 and the other array macros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.