fix(core): requeue HTTP ingest failures - #110
Open
Tyagiquamar wants to merge 2 commits into
Open
Tyagiquamar wants to merge 2 commits into
Tyagiquamar wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: e8676af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Hi, friendly ping for review on this PR when you have a moment. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchRoot Cause
Native
fetchresolves normally for HTTP 4xx and 5xx responses. The transport only handled rejected promises, so a non-2xx ingest response removed the batch from the queue permanently.Verification
pnpm --filter @smooai/observability exec vitest run src/__tests__/transport.test.tspassed: 7 testspnpm --filter @smooai/observability typecheckpassedpnpm exec oxfmt --check packages/core/src/transport.ts packages/core/src/__tests__/transport.test.tspassedgit diff --checkpassedPost-Deploy Monitoring & Validation
The existing ingest failure retry path remains the validation signal. No new production metric or configuration is introduced.