Skip to content

feat: allow canonical regulatory approvals - #148

Merged
SkyeAv merged 3 commits into
mainfrom
feat/allow-regulatory-approvals
Sep 10, 2026
Merged

feat: allow canonical regulatory approvals#148
SkyeAv merged 3 commits into
mainfrom
feat/allow-regulatory-approvals

Conversation

@SkyeAv

@SkyeAv SkyeAv commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Adds support for the canonical Biolink regulatory_approvals slot introduced by Biolink PR #1814 and removes the current Tablassert-specific handling of the legacy FDA-prefixed spelling.

Canonical Slot Override

  • Class-scoped grant: Adds regulatory_approvals to CLASS_FIELD_OVERRIDES only for EntityToDiseaseAssociation and EntityToPhenotypicFeatureAssociation.
  • Allow-list plumbing: Includes explicit class override grants in ALLOWED_EDGE_FIELDS without adding a global arbitrary-field allowance or TABLASERT_EDGE_EXTRAS entry.
  • Validation boundary: Preserves class-specific pruning, installed-model validation, unrelated-class rejection, and unknown-field handling.

Legacy Compatibility Removal

  • Current surfaces: Removes explicit FDA_regulatory_approvals references from src/, tests/, and docs/.
  • Dynamic model behavior: Keeps legitimate fields dynamically derived from the installed biolink-model; no broad compatibility allow-list was added.
  • Dependency caveat: The current environment uses biolink-model 4.4.4, which predates the upstream renamed slot. The explicit class-scoped grant bridges that dependency gap until the renamed slot reaches PyPI.

Regression Coverage and Docs

  • Pipeline behavior: Verifies category_override retention for both target classes, split_by conversion of pipe-delimited values into arrays, and _pruned_by_class evidence for ungranted classes.
  • Negative behavior: Retains rejection of unrelated class fields and arbitrary unknown fields.
  • Documentation: Updates docs/configuration/table.md with canonical spelling, class-scoped override guidance, and array encoding via split_by.

Testing

  • uv run --extra qc --extra agent pytest -q1408 passed, 3 skipped
  • make check → passed
  • uv run ruff check . → passed
  • uv run ruff format --check . → 88 files already formatted
  • uv run pyright → 0 errors, 0 warnings, 0 informations
  • if rg -n 'FDA_regulatory_approvals' src tests docs; then exit 1; fi → passed
  • Independent full-change audit → approved

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 137dae3f-af40-4331-a7f8-6e232533af76


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SkyeAv
SkyeAv merged commit bb88371 into main Sep 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant