feat: allow canonical regulatory approvals - #148
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the canonical Biolink
regulatory_approvalsslot introduced by Biolink PR #1814 and removes the current Tablassert-specific handling of the legacy FDA-prefixed spelling.Canonical Slot Override
regulatory_approvalstoCLASS_FIELD_OVERRIDESonly forEntityToDiseaseAssociationandEntityToPhenotypicFeatureAssociation.ALLOWED_EDGE_FIELDSwithout adding a global arbitrary-field allowance orTABLASERT_EDGE_EXTRASentry.Legacy Compatibility Removal
FDA_regulatory_approvalsreferences fromsrc/,tests/, anddocs/.biolink-model; no broad compatibility allow-list was added.biolink-model4.4.4, which predates the upstream renamed slot. The explicit class-scoped grant bridges that dependency gap until the renamed slot reaches PyPI.Regression Coverage and Docs
category_overrideretention for both target classes,split_byconversion of pipe-delimited values into arrays, and_pruned_by_classevidence for ungranted classes.docs/configuration/table.mdwith canonical spelling, class-scoped override guidance, and array encoding viasplit_by.Testing
uv run --extra qc --extra agent pytest -q→1408 passed, 3 skippedmake check→ passeduv run ruff check .→ passeduv run ruff format --check .→ 88 files already formatteduv run pyright→ 0 errors, 0 warnings, 0 informationsif rg -n 'FDA_regulatory_approvals' src tests docs; then exit 1; fi→ passed