Skip to content

GIANTS ModHub retest fixes: GUI profiles and default control - #4

Draft
SimGamerJen wants to merge 8 commits into
mainfrom
modhub-retest-fixes-20260825
Draft

GIANTS ModHub retest fixes: GUI profiles and default control#4
SimGamerJen wants to merge 8 commits into
mainfrom
modhub-retest-fixes-20260825

Conversation

@SimGamerJen

@SimGamerJen SimGamerJen commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Purpose

Address the latest GIANTS ModHub retest feedback without changing the mod's intended single-player scope.

Changes

  • Replace the layout-dependent KEY_quote default with the modifier combination KEY_lalt KEY_lshift KEY_a (Alt+Shift+A).
  • Explicitly set ignoreComboMask="false" for the Avatar Switcher action so the modifier combination behaves as a combo rather than a bare A action.
  • Update English, German and French ModHub descriptions using GIANTS' supplied wording, adjusted only so the documented default is Alt+Shift+A.
  • Add AS_GuiLifecycle.lua to load gui/guiProfiles.xml exactly once per game process.
  • Route both the selector and Wardrobe save dialog through the shared GUI-profile guard, preventing repeated registration of asButtonSaveEnter, asMetaText, asInputFieldButton, asButtonDelete, etc.
  • Update README control documentation to Alt+Shift+A.

Why this binding

The original apostrophe/quote binding is keyboard-layout dependent, and F11 proved unsuitable because FS25/debug tooling can bind it to render/debug visualisation functions. Alt+Shift+A avoids those issues and was checked against the current user inputBinding.xml with no exact or shorter modifier collision found for this combination.

Intentionally not changed yet

  • <multiplayer supported="false" /> remains unchanged. The mod is intentionally single-player and GIANTS' own requested replacement description explicitly says multiplayer is not supported. We should review this before any attempt to silence TestRunner by advertising unsupported multiplayer compatibility.

Review/test points

  1. Start FS25 with a clean log.
  2. Confirm Alt+Shift+A appears correctly in Controls and opens Avatar Switcher without triggering another action.
  3. Open/close/reopen Avatar Switcher several times.
  4. Open the Wardrobe, use Save to AvatarSwitcher, close/reopen the save dialog, then open the selector again.
  5. Confirm no GUI-Profile name ... already defined DevErrors are produced.
  6. Confirm saving, category selection/creation, applying and deleting presets still work as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant