GIANTS ModHub retest fixes: GUI profiles and default control - #4
Draft
SimGamerJen wants to merge 8 commits into
Draft
GIANTS ModHub retest fixes: GUI profiles and default control#4SimGamerJen wants to merge 8 commits into
SimGamerJen wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Address the latest GIANTS ModHub retest feedback without changing the mod's intended single-player scope.
Changes
KEY_quotedefault with the modifier combinationKEY_lalt KEY_lshift KEY_a(Alt+Shift+A).ignoreComboMask="false"for the Avatar Switcher action so the modifier combination behaves as a combo rather than a bareAaction.AS_GuiLifecycle.luato loadgui/guiProfiles.xmlexactly once per game process.asButtonSaveEnter,asMetaText,asInputFieldButton,asButtonDelete, etc.Why this binding
The original apostrophe/quote binding is keyboard-layout dependent, and F11 proved unsuitable because FS25/debug tooling can bind it to render/debug visualisation functions. Alt+Shift+A avoids those issues and was checked against the current user inputBinding.xml with no exact or shorter modifier collision found for this combination.
Intentionally not changed yet
<multiplayer supported="false" />remains unchanged. The mod is intentionally single-player and GIANTS' own requested replacement description explicitly says multiplayer is not supported. We should review this before any attempt to silence TestRunner by advertising unsupported multiplayer compatibility.Review/test points
GUI-Profile name ... already definedDevErrors are produced.