NEB-4781: Add KYC, geo, and bot-detection structured fields - #102
Open
rkumar-sift wants to merge 4 commits into
Open
NEB-4781: Add KYC, geo, and bot-detection structured fields#102rkumar-sift wants to merge 4 commits into
rkumar-sift wants to merge 4 commits into
Conversation
mzobro-sift
approved these changes
Sep 2, 2026
mzobro-sift
left a comment
mzobro-sift
left a comment
There was a problem hiding this comment.
LGTM, please update the description in changelog
Author
Done in 5309e0d — HISTORY now lists each field/event combination specifically instead of one generic line, matching the level of detail in the Java PR. |
mzobro-sift
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for the new structured fields (
$nationality,$year_of_birth,$kyc,$geo,$bot_identification) per the Structured Fields TDD (NEB-4573).Summary
client.track(event, properties)is a thin pass-through and does no field validation — properties are sent as-is, so no client code changes are needed for the new fields to work.$verification,$create_account,$login, and$transaction, using$-prefixed enum values ($basic/$full,$human/$bot/$suspected), consistent with other enum fields in this API (e.g.$login_status).HISTORYupdated.Testing
spec/unit/client_structured_fields_spec.rb, asserting the full field set round-trips correctly throughclient.track.Update 2026-09-02
Server-side dependency (NEB-4775) is now merged and deployed to production.
test_integration_app/events_api/test_events_api.rbfixtures, verified against real prod.HISTORYentry list each field/event combination specifically instead of one generic line.