[NEB-4779] Add KYC, geo, and bot-detection structured fields - #122
Open
rkumar-sift wants to merge 2 commits into
Open
[NEB-4779] Add KYC, geo, and bot-detection structured fields#122rkumar-sift wants to merge 2 commits into
rkumar-sift wants to merge 2 commits into
Conversation
mzobro-sift
reviewed
Sep 2, 2026
mzobro-sift
left a comment
mzobro-sift
left a comment
There was a problem hiding this comment.
please add new fields in tests in the test_integration_app/events_api/test_events_api.py
Author
Done in 14ddbc3. Added to create_account, update_account, login, transaction, build_create_order_event (covers create_order and update_order), and verification. Verified the exact payload shapes against production directly (curl) before pushing, all returning status:0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for the new structured fields (
$nationality,$year_of_birth,$kyc,$geo,$bot_identification) per the Structured Fields TDD (NEB-4573).Summary
client.track(event_type, properties)is fully generic and does no field validation — properties are sent as-is, so no client code changes are needed for the new fields to work.$transactionexample with$kyc/$geo/$bot_identification, using$-prefixed enum values ($basic/$full,$human/$bot/$suspected), consistent with other enum fields in this API (e.g.$login_status).CHANGES.mdupdated.Testing
python -m unittest discover, 83 tests).Update 2026-09-02
Server-side dependency (NEB-4775) is now merged and deployed to production. Addressed review:
test_integration_app/events_api/test_events_api.py(create_account,update_account,login,transaction,build_create_order_event,verification), verified against real prod.CHANGES.mdentry list each field/event combination specifically instead of one generic line.