[NEB-4780] Add KYC, geo, and bot-detection structured fields to integration tests - #117
Open
rkumar-sift wants to merge 1 commit into
Open
[NEB-4780] Add KYC, geo, and bot-detection structured fields to integration tests#117rkumar-sift wants to merge 1 commit into
rkumar-sift wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the new structured fields (
$nationality,$year_of_birth,$kyc,$geo,$bot_identification) to this repo's integration test fixtures, per the Structured Fields TDD (NEB-4573).Summary
No changes needed to
lib/itself. This client validates nothing client-side and is a thin HTTP wrapper, so callers can already pass these fields through as plain array keys. Added the fields to the existingcreate_account,update_account,login,transaction,create_order,update_order, andverificationfixtures intest_integration_app/events_api/test_events_api.php.Testing
Ran
test_integration_app/main.php's event methods directly against production (PHP 8.5 locally, standalone harness sincephpunit 7.*pinned incomposer.jsondoesn't support PHP 8+; CI's own matrix uses PHP 7.1-7.4, so this isn't a concern there). All 7 methods returnedhttpStatusCode=200,apiStatus=0.Also noticed
lib/SiftRequest.php'scurl_close()call is deprecated as of PHP 8.0 (no-op, harmless) — unrelated to this change, flagging separately rather than fixing here.