Detach adopted attributes from their elements - #724
Open
andrewiggins wants to merge 4 commits into
Open
andrewiggins wants to merge 4 commits into
andrewiggins wants to merge 4 commits into
Conversation
andrewiggins
added this pull request to stack #716
September 17, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detach an attached
Attrwhen passed toDocument.adoptNode(), including same-document adoption.@remote-dom/polyfill.Stack and scope
Stacked on #682 (
adopt-inserted-subtrees), which owns generic subtree adoption. This is the focused attached-Attr follow-up split from #693 and does not depend on indexed/named NamedNodeMap property access. Tests obtain attributes throughgetNamedItem()/getNamedItemNS().Validation
pnpm type-check,pnpm lint,pnpm build,pnpm size, andgit diff --check: passed.No existing pinned WPT test was found that directly adopts an attached Attr, so this PR does not change WPT classifications. Related adoption WPTs remain blocked by unrelated APIs/behavior. Polyfill-specific hooks and exception propagation are covered by unit tests, not claimed as native-browser equivalents.