Land default-namespace fixes on main - #714
Merged
Merged
Conversation
henrytao-me
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #678 was merged after its parent PR #677, but GitHub left its base set to the already-merged
normalize-dom-namespacesbranch. The merge therefore advanced that branch instead ofmain.The #677 normalization work is present in
main, but #678’sisDefaultNamespace()correction, tests, and changeset are not.Impact
The reviewed namespace-context fix is marked merged without being part of the release branch. The remaining dependent PRs also cannot safely continue until this layer is reachable from
main.Change
Replay the exact reviewed #678 patch on current
main:The stable patch ID is unchanged from #678 (
c379a3b9dd0e45940251ae608c2c7f4cdbf8e136). This PR does not add new behavior beyond the already-reviewed layer.Tests
Local validation on current
mainpasses:Fresh GitHub CI is still required on this replacement head.
Ordering
This replaces the incorrectly targeted merge from #678. Land it before retargeting #679 and the remaining #677-dependent stack roots to
main.