Skip to content

Revert "Avoid bundling TypeScript in the production CLI" - #8263

Merged
isaacroldan merged 1 commit into
mainfrom
revert-8248-isaac/externalize-typescript-from-cli-bundle
Aug 7, 2026
Merged

Revert "Avoid bundling TypeScript in the production CLI"#8263
isaacroldan merged 1 commit into
mainfrom
revert-8248-isaac/externalize-typescript-from-cli-bundle

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

Reverts #8248

Using this snapshot:

❯ shopify app dev
╭─ error ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                                           │
│  Cannot find package 'typescript' imported from                                                                                                           │
│  /Users/gonzalo/Library/pnpm/global/5/.pnpm/@shopify+cli@0.0.0-snapshot-20260804105319/node_modules/@shopify/cli/dist/chunk-73JGNLLL.js                   │
│                                                                                                                                                           │
│  To investigate the issue, examine this stack trace:                                                                                                      │
│    at 0-snapshot-20260804105319/node_modules/                                                                                                             │
│    at getPackageJSONURL (node:internal/modules/package_json_reader:301)                                                                                   │
│    at packageResolve (node:internal/modules/esm/resolve:764)                                                                                              │
│    at moduleResolve (node:internal/modules/esm/resolve:855)                                                                                               │
│    at defaultResolve (node:internal/modules/esm/resolve:988)                                                                                              │
│    at #cachedDefaultResolve (node:internal/modules/esm/loader:697)                                                                                        │
│    at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:714)                                                                          │
│    at resolveSync (node:internal/modules/esm/loader:746)                                                                                                  │
│    at #resolve (node:internal/modules/esm/loader:679)                                                                                                     │
│    at getOrCreateModuleJob (node:internal/modules/esm/loader:599)                                                                                         │
│    at (node:internal/modules/esm/loader:628)                                                                                                              │
│                                                                                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner August 7, 2026 11:35
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 7, 2026
@gonzaloriestra

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260807115428

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@isaacroldan
isaacroldan added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 73f51a1 Aug 7, 2026
30 checks passed
@isaacroldan
isaacroldan deleted the revert-8248-isaac/externalize-typescript-from-cli-bundle branch August 7, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants