Fix actionable upstream issues - #5
Merged
Merged
Conversation
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the actionable upstream findings that were grouped in the fork issues below. It is intentionally left open for review and is not merged.
Split,HSplit, andVSplitFractionHolder state stable across SwiftUI view reconstruction.onChangeobservation in the library, demo, and README without raising deployment targets.columnResizeCursor/rowResizeCursoron macOS 15 and later, retain a deployment-saferesizeLeftRight/resizeUpDownfallback for macOS 12–14, keep the existing Catalyst fallback, and prevent the cursor overlay from intercepting drag gestures.Upstream context:
Review follow-up
Splitnow owns its default FractionHolder with@StateObject;.fraction(FractionHolder)keeps an explicit caller-owned holder separate and observed.fractionSeedinstead of reading a wrapped@StateObject; onlybodyreads the installed object when composing the childSplit.StateObject, so replacing a caller-owned holder during a mounted View rebuild does not retain the old holder in SwiftUI state storage..animation(.default, value: hide.side?.rawValue)so callers control whether hide/show changes animate and which transaction animation is used.onChangesource check now targets the deprecated one-argument closure shape instead of matching every overload.NSHostingViewrebuild regression test that verifies a replaced caller-owned holder is released and no pre-installStateObjectaccess warning occurs.Implementation notes
Verification
swift test --scratch-path /tmp/SplitView-review-full-tests— 14 tests, 0 failuresswift test --scratch-path /tmp/SplitView-review-lifecycle-green --filter 'ObservationTests|StateObjectLifecycleTests'— 4 tests, 0 failuresswift build --scratch-path /tmp/SplitView-review-macos— passedswift build --sdk "$(xcrun --sdk iphoneos --show-sdk-path)" --triple arm64-apple-ios15.0 --scratch-path /tmp/SplitView-review-iphoneos— passedswift build --sdk "$(xcrun --sdk macosx --show-sdk-path)" --triple arm64-apple-ios15.0-macabi --scratch-path /tmp/SplitView-review-catalyst— passedxcodebuildbuilds for macOS, iOS, and Mac Catalyst — all exit 0; the Demo currently resolves the upstream Package URL, so these validate the example project rather than directly integrating the local fork checkoutgit diff --check— passedNo comments or messages were posted to the upstream repository.