fix datastream redis keys doubling the schematic prefix - #53
Merged
Conversation
ResourceCache prepended "schematic" while RedisCacheProvider already adds the "schematic:" key prefix, so company and user keys were written as schematic:schematic:company:... and never matched what the replicator writes. Flags already relied on the provider prefix alone. Also lowercase lookup values, as the replicator and the other SDKs do. The testapp leaves the datastream caches on the default TTL like the Go testapp: a 2s TTL on the write-back after track() expires the replicator-owned entries.
bpapillon
marked this pull request as ready for review
September 5, 2026 06:22
schematic-bot
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ruby / replicator E2E failures (SCH-7065).
ResourceCache prepended "schematic" to company and user keys while RedisCacheProvider already adds the "schematic:" prefix, so Redis held schematic:schematic:company:... and lookups against the replicator (which writes schematic:company:::) always missed. Flags already relied on the provider prefix alone, which is why flag checks worked and only company/user context did not. Also lowercases lookup values, matching the replicator and the other SDKs.
The testapp now leaves the datastream entity caches on the SDK default TTL, matching the Go testapp: with a 2s TTL, the write-back after track() would expire the replicator-owned entries (the same failure python#105 fixed).