coerce cached flag responses from serializing cache providers (SCH-7065) - #51
Merged
Conversation
RedisCacheProvider round-trips values through JSON and hands back a Hash, but the flag-check cache path called .value on it, so every cache hit in Redis cache mode raised and fell back to the flag default.
bpapillon
marked this pull request as ready for review
September 5, 2026 00:13
schematic-bot
approved these changes
Sep 5, 2026
schematic-bot
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Redis cache mode every flag-check cache hit failed with
undefined method 'value' for an instance of Hashand fell back to the flag default (SDK E2Eredisandreplicatormodes, SCH-7065).RedisCacheProvider#getreturns the JSON-parsed Hash, whilecheck_flag_via_apiandcheck_flagsexpected theCheckFlagResponsethat was stored.Normalizes a Hash back into
CheckFlagResponseat both read sites, with a test using a JSON round-tripping cache provider.