tolerate unknown datastream envelope fields (SCH-7065) - #97
Merged
Conversation
The datastream server added stream_id to every message; Jackson's default FAIL_ON_UNKNOWN_PROPERTIES made the client drop every message, so no flag, company or user update was ever applied. Ignore unknown fields on the envelope types and expose stream_id for replay.
bpapillon
marked this pull request as ready for review
September 5, 2026 00:13
schematic-bot
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every datastream message now carries
stream_id, and the envelope classes used Jackson's default of rejecting unknown properties, soDataStreamWebSocketClientloggedFailed to parse datastream message: Unrecognized field "stream_id"and applied no updates at all. Found by the SDK E2E datastream modes (SCH-7065):TestFlipFlagDefaultandTestTrackEventFlipsMetricGatedFlagtime out because the SDK never sees the change.Marks the envelope types
@JsonIgnoreProperties(ignoreUnknown = true)so future server-side additions cannot break parsing, and addsstreamIdtoDataStreamRespfor replay-on-reconnect later.