Refactor 24 trend new - #216
Open
gonzalezma wants to merge 1 commit into
Open
Conversation
… previous refactor_24_trend branch
Collaborator
|
Yes, this is much easier to review. I'll close the other PR in favor of this one. |
Closed
krzywon
approved these changes
Aug 19, 2026
krzywon
left a comment
krzywon
left a comment
Collaborator
There was a problem hiding this comment.
This looks like it takes into multi-dimensional trends properly. Look at the one comment I made to be sure that doesn't affect functionality before merging.
| if type(self.contents) is str: | ||
| children = f"\n{header} {self.contents}" | ||
| else: | ||
| match self.contents: |
Collaborator
There was a problem hiding this comment.
This match isn't completely equivalent to the previous if/else block. If self.contents == "", the new check will give children == f"\n{header} {self.contents}", but gave an empty string before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New trend branch created directly from refactor_24. It contains the changes done in March to the original Trend class to allow defining an arbitrary number of axes in the Trend (populated either from the metadata or by giving a list of numerical values) and new tests, as well as some improvements to address the review comments in the previous refactor_24_trend branch.