Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/demo_app/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module(
)

# Uses the local checkout because rules_flutter is not published.
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
local_path_override(
module_name = "sameri11_rules_flutter",
path = "../..",
Expand Down
2 changes: 1 addition & 1 deletion examples/local_plugin/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module(

# Monorepo app with a local path plugin. It exercises non-root metadata and
# plugin paths outside the pub cache.
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
local_path_override(
module_name = "sameri11_rules_flutter",
path = "../..",
Expand Down
2 changes: 1 addition & 1 deletion examples/no_plugins/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module(

# Minimal plugin-free module: no plugins.project(), generated segment, or
# @flutter_plugins repository.
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
local_path_override(
module_name = "sameri11_rules_flutter",
path = "../..",
Expand Down
2 changes: 1 addition & 1 deletion examples/pub_plugins/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module(
)

# Copyable flat app: pub plugins, one ABI, no recipes or path dependencies.
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
local_path_override(
module_name = "sameri11_rules_flutter",
path = "../..",
Expand Down
3 changes: 3 additions & 0 deletions flutter/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package(default_visibility = ["//visibility:public"])

exports_files(["defs.bzl"])
53 changes: 53 additions & 0 deletions flutter/defs.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
"""Supported BUILD-file API for Flutter Consumer Modules.

Consumer BUILD files load this entrypoint, not ``//tools/flutter``. These
exports are the complete consumer contract; implementation may move without a
consumer migration.
"""

load("//tools/flutter:abis.bzl", _ABIS = "ABIS")
load(
"//tools/flutter:android.bzl",
_android_native_lib_jar = "android_native_lib_jar",
_flutter_android_binary = "flutter_android_binary",
_flutter_android_libs = "flutter_android_libs",
_jni_lib_jar = "jni_lib_jar",
_strip_native_libs = "strip_native_libs",
)
load(
"//tools/flutter:defs.bzl",
_dart_kernel = "dart_kernel",
_flutter_aot_library = "flutter_aot_library",
_flutter_app = "flutter_app",
_flutter_assets = "flutter_assets",
_pub_path_deps_check = "pub_path_deps_check",
_pub_plugins_check = "pub_plugins_check",
)
load(
"//tools/flutter:embedding.bzl",
_flutter_embedding_library = "flutter_embedding_library",
)
load("//tools/flutter:pubspec.bzl", _flutter_pubspec = "flutter_pubspec")
load(
"//tools/flutter:recipe.bzl",
_flutter_native_contribution = "flutter_native_contribution",
_flutter_native_libs = "flutter_native_libs",
)

# Assigning these names re-exports them to downstream BUILD files.
ABIS = _ABIS
android_native_lib_jar = _android_native_lib_jar
dart_kernel = _dart_kernel
flutter_android_binary = _flutter_android_binary
flutter_android_libs = _flutter_android_libs
flutter_aot_library = _flutter_aot_library
flutter_app = _flutter_app
flutter_assets = _flutter_assets
flutter_embedding_library = _flutter_embedding_library
flutter_native_contribution = _flutter_native_contribution
flutter_native_libs = _flutter_native_libs
flutter_pubspec = _flutter_pubspec
jni_lib_jar = _jni_lib_jar
pub_path_deps_check = _pub_path_deps_check
pub_plugins_check = _pub_plugins_check
strip_native_libs = _strip_native_libs
46 changes: 37 additions & 9 deletions tests/consumer/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,16 +1,44 @@
"""Every public symbol, instantiated the way a consumer would.
"""Supported BUILD API, including macro-internal coverage.

This is an API test, not a behaviour test.
Public symbols load from @rules_flutter//flutter:defs.bzl. Specialist loads
cover private helpers, not Consumer Module API.
"""

load("@bazel_skylib//rules:build_test.bzl", "build_test")
load("@rules_flutter//tools/flutter:abis.bzl", "ABIS", "aot_gen_snapshot", "aot_target_compatible_with", "plugin_repo_target")
load("@rules_flutter//tools/flutter:android.bzl", "android_native_lib_jar", "flutter_android_binary", "flutter_android_libs", "flutter_assets_dir", "jni_lib_jar", "strip_native_libs")
load("@rules_flutter//tools/flutter:bundle.bzl", "CLASSES", "NATIVE_LIB", "flutter_bundle_contribution")
load("@rules_flutter//tools/flutter:defs.bzl", "dart_aot_elf", "dart_kernel", "flutter_aot_library", "flutter_assets", "pub_path_deps_check", "pub_plugins_check")
load("@rules_flutter//tools/flutter:embedding.bzl", "flutter_embedding_library")
load("@rules_flutter//tools/flutter:pubspec.bzl", "flutter_pubspec")
load("@rules_flutter//tools/flutter:recipe.bzl", "flutter_native_contribution", "flutter_native_libs")
load(
"@rules_flutter//flutter:defs.bzl",
"ABIS",
"android_native_lib_jar",
"dart_kernel",
"flutter_android_binary",
"flutter_android_libs",
"flutter_aot_library",
"flutter_assets",
"flutter_embedding_library",
"flutter_native_contribution",
"flutter_native_libs",
"flutter_pubspec",
"jni_lib_jar",
"pub_path_deps_check",
"pub_plugins_check",
"strip_native_libs",
)
load(
"@rules_flutter//tools/flutter:abis.bzl",
"aot_gen_snapshot",
"aot_target_compatible_with",
"plugin_repo_target",
)
load("@rules_flutter//tools/flutter:android.bzl", "flutter_assets_dir")
load(
"@rules_flutter//tools/flutter:bundle.bzl",
"CLASSES",
"NATIVE_LIB",
"flutter_bundle_contribution",
)

# Macro-internal coverage only; not Consumer Module API.
load("@rules_flutter//tools/flutter:defs.bzl", "dart_aot_elf")
load("@rules_java//java:defs.bzl", "java_import")
load(":assertions.bzl", "expect_equal", "expect_label_equal")

Expand Down
2 changes: 1 addition & 1 deletion tests/consumer/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module(
version = "0.0.1",
)

bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
bazel_dep(name = "bazel_skylib", version = "1.8.2")

local_path_override(
Expand Down
2 changes: 1 addition & 1 deletion tests/consumer/external_app/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module(
version = "0.0.1",
)

bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")

# Report and ignore unmatched dependency recipes.
plugins = use_extension("@rules_flutter//tools/flutter:plugins.bzl", "flutter_plugins_ext")
Expand Down
2 changes: 1 addition & 1 deletion tests/consumer/external_app/app/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@rules_flutter//tools/flutter:defs.bzl", "flutter_app")
load("@rules_flutter//flutter:defs.bzl", "flutter_app")

package(default_visibility = ["//visibility:public"])

Expand Down
2 changes: 1 addition & 1 deletion tests/consumer/standard_layout/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# package pairs that with `plugins = None`, proving the complete shape creates no
# @flutter_plugins label and defaults to no federated Dart registrant.

load("@rules_flutter//tools/flutter:defs.bzl", "flutter_app")
load("@rules_flutter//flutter:defs.bzl", "flutter_app")

package(default_visibility = ["//visibility:public"])

Expand Down
2 changes: 1 addition & 1 deletion tests/core_consumer/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module(
version = "0.0.1",
)

bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", version = "0.1.0", repo_name = "rules_flutter")
local_path_override(
module_name = "sameri11_rules_flutter",
path = "../..",
Expand Down