Skip to content

01: Correct module identity and source-version semantics #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sameri11 wants to merge 1 commit into from
Closed

01: Correct module identity and source-version semantics #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module(
name = "rules_flutter",
version = "0.1.0",
name = "sameri11_rules_flutter",
)

flutter = use_extension("//tools/flutter:repo.bzl", "flutter")
Expand Down
6 changes: 3 additions & 3 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions QUICKSTART.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ Until `rules_flutter` is published to the Bazel Central Registry, create a
consumer as a sibling of a checkout and retain a development override:

```python
bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../rules_flutter",
)
```
Expand Down Expand Up @@ -131,9 +131,9 @@ details out of the root `MODULE.bazel`:
```python
module(name = "hello_bazel", version = "0.0.1")

bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../rules_flutter",
)

Expand Down Expand Up @@ -582,9 +582,9 @@ module(
version = "0.0.1",
)

bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../..",
)

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ Create the root `MODULE.bazel` (the `local_path_override` is development-only un
```python
module(name = "hello_bazel", version = "0.0.1")

bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../rules_flutter",
)

Expand Down
4 changes: 2 additions & 2 deletions examples/demo_app/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ module(
)

# Uses the local checkout because rules_flutter is not published.
bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../..",
)

Expand Down
286 changes: 143 additions & 143 deletions examples/demo_app/MODULE.bazel.lock
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/local_plugin/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ module(

# Monorepo app with a local path plugin. It exercises non-root metadata and
# plugin paths outside the pub cache.
bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../..",
)

Expand Down
276 changes: 138 additions & 138 deletions examples/local_plugin/MODULE.bazel.lock
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/no_plugins/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ module(

# Minimal plugin-free module: no plugins.project(), generated segment, or
# @flutter_plugins repository.
bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../..",
)

Expand Down
170 changes: 85 additions & 85 deletions examples/no_plugins/MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions examples/pub_plugins/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ module(
)

# Copyable flat app: pub plugins, one ABI, no recipes or path dependencies.
bazel_dep(name = "rules_flutter", version = "0.1.0")
bazel_dep(name = "sameri11_rules_flutter", repo_name = "rules_flutter", version = "0.1.0")
local_path_override(
module_name = "rules_flutter",
module_name = "sameri11_rules_flutter",
path = "../..",
)

Expand Down
Loading
Loading