Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/demo_app/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/local_plugin/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/pub_plugins/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/consumer/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions tools/flutter/plugins.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1026,13 +1026,17 @@ def _flutter_plugins_impl(ctx):
if override != None:
used_overrides.append(name)

# An override that clears nothing is dead weight, and dead weight
# drifts out of date unnoticed. Recorded, not failed: what it
# supplies is still correct, so the build is right either way.
if "unresolved_dep" not in reasons:
# Stale only when it does neither thing it can do: clear
# `unresolved_dep`, or contribute a coordinate the scraper missed --
# which is how a classless KMP root gets its `-android`/`-jvm`
# child. Judging by the gate alone called those dead and told the
# consumer to delete them, silently dropping the coordinate.
# Recorded, not failed: what it supplies is correct either way.
contributed = [c for c in override if c not in coordinates]
if "unresolved_dep" not in reasons and not contributed:
stale_overrides.append(name)

coordinates = coordinates + [c for c in override if c not in coordinates]
coordinates = coordinates + contributed
reasons = [r for r in reasons if r != "unresolved_dep"]

gated = [r for r in reasons if r in _GATED_REASONS]
Expand Down