Feature check body before 100 continue - #1
Open
SamRemis wants to merge 1879 commits into
Open
Conversation
* release-1.29.74: Bumping version to 1.29.74 Update to latest partitions and endpoints Update to latest models
* release-1.29.75: Bumping version to 1.29.75 Update to latest models Plumb profile_name into SSOTokenProvider
* release-1.29.76: Bumping version to 1.29.76 Update to latest partitions and endpoints Update to latest models
* release-1.29.77: Bumping version to 1.29.77 Update to latest models
* release-1.29.78: Bumping version to 1.29.78 Update to latest partitions and endpoints Update to latest models
* release-1.29.79: Bumping version to 1.29.79 Update to latest models
* release-1.29.80: Bumping version to 1.29.80 Update to latest partitions and endpoints Update to latest models upgrade isort (boto#2877)
* release-1.29.82: Bumping version to 1.29.82 Update to latest partitions and endpoints Update to latest models
* release-1.29.83: Bumping version to 1.29.83 Update to latest partitions and endpoints Update to latest models
* release-1.29.84: Bumping version to 1.29.84 Update to latest partitions and endpoints Update to latest models
* release-1.29.85: Bumping version to 1.29.85 Update to latest models
* release-1.29.86: Bumping version to 1.29.86 Update to latest partitions and endpoints Update to latest models
* release-1.29.87: Bumping version to 1.29.87 Update to latest partitions and endpoints Update to latest models
* release-1.29.88: Bumping version to 1.29.88 Update to latest partitions and endpoints Update to latest models
* release-1.29.89: Bumping version to 1.29.89 Update to latest partitions and endpoints Update to latest models Add timezone info to the datetime instances used in test_token_chosen_from_provider (boto#2882)
* release-1.29.90: Bumping version to 1.29.90 Update to latest partitions and endpoints Update to latest models
* release-1.29.91: Bumping version to 1.29.91 Update to latest partitions and endpoints Update to latest models
* release-1.29.92: Bumping version to 1.29.92 Update to latest partitions and endpoints Update to latest models
* release-1.29.94: Bumping version to 1.29.94 Update to latest partitions and endpoints Update to latest models
* release-1.29.95: Bumping version to 1.29.95 Update to latest partitions and endpoints Update to latest models Added furo theme to botocore documentation. (boto#2888)
* release-1.29.96: Bumping version to 1.29.96 Update to latest partitions and endpoints Update to latest models
* release-1.29.97: Bumping version to 1.29.97 Update to latest partitions and endpoints Update to latest models
* release-1.29.99: Bumping version to 1.29.99 Update to latest partitions and endpoints Update to latest models
* release-1.29.100: Bumping version to 1.29.100 Update to latest models
* release-1.29.101: Bumping version to 1.29.101 Update to latest partitions and endpoints Update to latest models Fix links and code edge cases in docs generation (boto#2896)
* release-1.29.102: Bumping version to 1.29.102 Update to latest partitions and endpoints Update to latest models Sms voice fix (boto#2894)
* release-1.29.103: Bumping version to 1.29.103 Update to latest partitions and endpoints Update to latest models Accessibility Issues (boto#2897)
* release-1.34.26: Bumping version to 1.34.26 Update to latest models
* release-1.34.27: Bumping version to 1.34.27 Update to latest models
* release-1.34.28: Bumping version to 1.34.28 Update to latest models
* release-1.34.29: Bumping version to 1.34.29 Update to latest models Minor GitHub workflow changes (boto#3104)
* release-1.34.30: Bumping version to 1.34.30 Update to latest partitions and endpoints Update to latest models
* release-1.34.31: Bumping version to 1.34.31 Update to latest models
* release-1.34.32: Bumping version to 1.34.32 Update to latest partitions and endpoints Update to latest models
* release-1.34.33: Bumping version to 1.34.33 Update to latest partitions and endpoints Update to latest models Fix pytest-8.0.0 test failures due to incorrect `pytest.warns()` (boto#3109)
* release-1.34.34: Bumping version to 1.34.34 Update to latest partitions and endpoints Update to latest models
* release-1.34.35: Bumping version to 1.34.35 Update to latest models Bump codecov/codecov-action from 3.1.4 to 4.0.1 (boto#3113)
* release-1.34.36: Bumping version to 1.34.36 Update to latest models
* release-1.34.37: Bumping version to 1.34.37 Update to latest partitions and endpoints Update to latest models
* release-1.34.38: Bumping version to 1.34.38 Update to latest models
* release-1.34.39: Bumping version to 1.34.39 Update to latest partitions and endpoints Update to latest models Add includeMemberAccounts as non aggregrate key
* release-1.34.40: Bumping version to 1.34.40 Update to latest models
* release-1.34.41: Bumping version to 1.34.41 Update to latest partitions and endpoints Update to latest models Fix EKS credentials refresh bug (boto#3114)
SamRemis
force-pushed
the
feature-check-body-before-100-continue
branch
3 times, most recently
from
February 16, 2024 03:39
5675b5e to
30c6146
Compare
nateprewitt
reviewed
Feb 16, 2024
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Minor comment, but otherwise looks reasonable.
| if hasattr(body, 'read'): | ||
| check_body = utils.ensure_boolean( | ||
| os.environ.get( | ||
| 'BOTO_EXPERIMENTAL__CHECK_BODY_BEFORE_CONTINUE', |
There was a problem hiding this comment.
nit; the name could be a bit more succinct.
Suggested change
| 'BOTO_EXPERIMENTAL__CHECK_BODY_BEFORE_CONTINUE', | |
| 'BOTO_EXPERIMENTAL__NO_EMPTY_CONTINUE', |
or
Suggested change
| 'BOTO_EXPERIMENTAL__CHECK_BODY_BEFORE_CONTINUE', | |
| 'BOTO_EXPERIMENTAL__NO_EMPTY_100', |
SamRemis
force-pushed
the
feature-check-body-before-100-continue
branch
from
February 16, 2024 20:12
30c6146 to
3b95e2a
Compare
SamRemis
force-pushed
the
develop
branch
2 times, most recently
from
September 25, 2024 13:43
b284a81 to
30def51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.