Skip to content

[autobackport: sssd-2-13] test rewrite: legacy intg test_pam_responder.py - first batch - #9155

Open
sssd-bot wants to merge 2 commits into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr9004-to-sssd-2-13
Open

[autobackport: sssd-2-13] test rewrite: legacy intg test_pam_responder.py - first batch#9155
sssd-bot wants to merge 2 commits into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr9004-to-sssd-2-13

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#9004 test rewrite: legacy intg test_pam_responder.py - first batch to branch sssd-2-13, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr9004-to-sssd-2-13
git checkout SSSD-sssd-backport-pr9004-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr9004-to-sssd-2-13 --force

Original commits
2d2dafd - test rewrite: legacy intg test_pam_responder.py - first batch
3e43f26 - test(smartcard): use client.auth.su.vlock_smartcard() in vlock test

Backported commits

  • f739684 - CONFLICT! test rewrite: legacy intg test_pam_responder.py - first batch
  • 0411dcc - test(smartcard): use client.auth.su.vlock_smartcard() in vlock test

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! test rewrite: legacy intg test_pam_responder.py - first batch
On branch SSSD-sssd-backport-pr9004-to-sssd-2-13
You are currently cherry-picking commit 2d2dafdda.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/tests/system/tests/test_authentication.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_smartcard.py

Original Pull Request Body

Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py

  • test_smartcard__login_fails_when_wrong_pin_is_entered
  • test_smartcard__login_fails_when_card_is_not_mapped
  • test_smartcard__cert_auth_limited_to_allowed_pam_services
  • test_smartcard__login_succeeds_when_cert_auth_required
  • test_smartcard__login_fails_when_cert_auth_required_without_card
  • test_authentication__custom_password_prompt_is_shown_at_login

Peeling out the reviewed test cases into it's own PR, from #8873

Depends on the following test-framework PR SSSD/sssd-test-framework#262

Model used: Claude Sonnet 4.6

@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr9004-to-sssd-2-13 branch from 0411dcc to 984e64b Compare August 26, 2026 18:48
@danlavu
danlavu marked this pull request as ready for review August 26, 2026 18:56
Dan Lavu and others added 2 commits August 26, 2026 15:15
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py,
test_authentication.py

- test_smartcard__login_fails_when_wrong_pin_is_entered
- test_smartcard__login_fails_when_card_is_not_mapped
- test_smartcard__cert_auth_limited_to_allowed_pam_services
- test_smartcard__login_succeeds_when_cert_auth_required
- test_smartcard__login_fails_when_cert_auth_required_without_card
- test_authentication__custom_password_prompt_is_shown_at_login

Peeling out the reviewed test cases into it's own PR, from
SSSD#8873

AI: Claude Sonnet 4.6
Co-authored-by: Cursor <cursoragent@cursor.com>
Replace inline expect script in test_smartcard__unlock_console_with_vlock
with client.auth.su.vlock_smartcard(), moving the logic into the
test framework.

Co-authored-by: Cursor <cursoragent@cursor.com>
@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr9004-to-sssd-2-13 branch from 984e64b to c882d18 Compare August 26, 2026 19:21
@danlavu danlavu added no-backport This should go to target branch only. Tests labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport This should go to target branch only. Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants