[autobackport: sssd-2-13] test rewrite: legacy intg test_pam_responder.py - first batch - #9155
Open
sssd-bot wants to merge 2 commits into
Open
[autobackport: sssd-2-13] test rewrite: legacy intg test_pam_responder.py - first batch#9155sssd-bot wants to merge 2 commits into
sssd-bot wants to merge 2 commits into
Conversation
danlavu
force-pushed
the
SSSD-sssd-backport-pr9004-to-sssd-2-13
branch
from
August 26, 2026 18:48
0411dcc to
984e64b
Compare
danlavu
marked this pull request as ready for review
August 26, 2026 18:56
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py - test_smartcard__login_fails_when_wrong_pin_is_entered - test_smartcard__login_fails_when_card_is_not_mapped - test_smartcard__cert_auth_limited_to_allowed_pam_services - test_smartcard__login_succeeds_when_cert_auth_required - test_smartcard__login_fails_when_cert_auth_required_without_card - test_authentication__custom_password_prompt_is_shown_at_login Peeling out the reviewed test cases into it's own PR, from SSSD#8873 AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
Replace inline expect script in test_smartcard__unlock_console_with_vlock with client.auth.su.vlock_smartcard(), moving the logic into the test framework. Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
SSSD-sssd-backport-pr9004-to-sssd-2-13
branch
from
August 26, 2026 19:21
984e64b to
c882d18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9004 test rewrite: legacy intg test_pam_responder.py - first batch to branch sssd-2-13, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
2d2dafd - test rewrite: legacy intg test_pam_responder.py - first batch
3e43f26 - test(smartcard): use client.auth.su.vlock_smartcard() in vlock test
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py
Peeling out the reviewed test cases into it's own PR, from #8873
Depends on the following test-framework PR SSSD/sssd-test-framework#262
Model used: Claude Sonnet 4.6