fix: 根据双行显示状态隐藏任务栏歌词翻译选项 - #253
Open
SuzakuinAyaka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动类型
是否包含破坏性变更
改动说明
设置-外部歌词-任务栏歌词:单行模式(即关闭双行显示选项)下的“显示翻译”选项不会产生实际效果,容易让用户误解。此PR尝试修改为仅在开启“双行显示”时才会显示翻译选项。
本次改动复用 Setting schema 现有的
visible()条件显示机制:showTranslation配置值;关联 Issue
暂无
测试情况
pnpm formatpnpm typecheckpnpm lint截图 / 录屏
开启双行显示,此时“显示翻译”渲染


关闭双行显示,此时“显示翻译”不渲染
反复重启双行显示,确认“显示翻译”选项不会被重置




(启用“显示翻译”,并确认开关双行显示不会影响该选项的值)
自查清单
pnpm format,并确认pnpm typecheck、pnpm lint通过pnpm build:native验证;未手写native/*/index.d.tsdev分支提交